[kwvg]

Motivation

Build failures (source) that did not appear until after the cache was warmed by the merger of base-sdk#96 causing failures in an unrelated PR, base-sdk#97.

Request for backporting the fix for the underlying cause has been made in bazelbuild/bazel#32219 but until it makes it into a released version of Bazel or we get to revert base-sdk#72, we have to revert the change itself.

How Has This Been Tested?

BAZELISK_HOME=.cache/bazelisk bazelisk mod deps --lockfile_mode=error
cargo check --locked
uv lock --check
just lint

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional tests
• I have made corresponding changes to the documentation
• I did not use agentic assistance (i.e. LLMs, AI) except as disclosed and can answer questions, comments and concerns without said assistance. I assume authorship of the code submitted.
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

Agent disclosure

Not applicable.

[github-actions]

Warning

This pull request may have conflicts, please coordinate with the authors of these pull requests.

Potential conflicts

• sdk%chore(ci): bump the actions group across 3 directories with 5 updates #97

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: dashpay/base-sdk
• Branch: develop
• File: .coderabbit.yml
• Commit: 5a11e0a
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 58985c41-dbf3-4105-9c3f-747943e6a457

Commits

Reviewing files that changed from the base of the PR and between 5a11e0a and fe616d5.

Files ignored due to path filters: 5

• Cargo.lock is excluded by !**/*.lock, !**/*.lock
• contrib/nix/flake.lock is excluded by !**/*.lock, !**/*.lock
• docs/samples/Cargo.lock is excluded by !**/*.lock, !**/*.lock
• fuzz/Cargo.lock is excluded by !**/*.lock, !**/*.lock
• uv.lock is excluded by !**/*.lock, !**/*.lock

Files selected for processing: 10

• .github/actions/bazel_remote/action.yml
• .github/workflows/build_bazel.yml
• .github/workflows/pkg_num.yml
• .github/workflows/pkg_p2p_core.yml
• .github/workflows/pkg_params.yml
• .github/workflows/pkg_pkc.yml
• .github/workflows/pkg_pow.yml
• .github/workflows/pkg_primitives.yml
• .github/workflows/pkg_script.yml
• .github/workflows/pkg_types.yml

Files with no reviewable changes: 1

• .github/actions/bazel_remote/action.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Summary

Summary by CodeRabbit

• Chores
  • Build and package workflows now run on pushes to the develop branch, with the peer-to-peer core workflow scoped to that branch.
  • The Bazel remote action no longer adds the remote repository contents cache option to the user configuration. This changes the build configuration used by that action.

Nine GitHub Actions workflows have updated push branch filters involving develop. The build_bazel workflow is limited to pushes to develop. The Bazel remote action no longer adds --experimental_remote_repo_contents_cache to Bazel startup.

Suggested reviewers: thepastaclaw

Merge Risk: Minimal · up to fe616

No concrete merge-blocking issue was found in the reviewed workflow and Bazel action changes.

Pre-merge checks: 4

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description check		The description states the motivation: build failures appeared after a cache was warmed by a prior merge, and the change reverts the cache-related setting. It also lists the commands used for testing.…
Title check		The title accurately describes the pull request. It identifies the Bazel-related partial revert, workflow trigger fixes, lockfile refreshes, dependency warning resolution, and Markdown lint fixes. It …

Full details: Description check

Explanation

The description states the motivation: build failures appeared after a cache was warmed by a prior merge, and the change reverts the cache-related setting. It also lists the commands used for testing. It relates directly to the changeset, which removes the remote repo contents cache startup flag and limits workflow triggers.

Full details: Title check

Explanation

The title accurately describes the pull request. It identifies the Bazel-related partial revert, workflow trigger fixes, lockfile refreshes, dependency warning resolution, and Markdown lint fixes. It is lengthy, but it is specific and related to the changes.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[thepastaclaw]

⏹️ Not reviewed — a label on the PR turns automatic review off; @thepastaclaw review still asks for one (commit bbc3972)