Repository navigation
backport: bitcoin/bitcoin#26905, #27724, #28482, partial #29659 - clang-tidy [perf] - #7693
Conversation
lint-tidy.sh appends clang-diagnostic-old-style-cast and google-readability-casting via -checks and relies on them staying warnings: lint-cstyle-casts.py only fails the job for casts in files listed in test/util/data/non-backported.txt and filters everything else out. With WarningsAsErrors: '*' from bitcoin#26905 every cast in upstream code becomes an error, clang-tidy exits non-zero and run-clang-tidy fails the job before the filter gets to decide. -warnings-as-errors is appended to the value from .clang-tidy, so negating the two checks on the command line keeps the config file identical to upstream.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughThe change updates clang-tidy and Boost multi_index build settings. It replaces temporary container construction with direct emplacement, adds capacity reservations, and avoids selected copies across core, GUI, RPC, and wallet code. It removes the explicit Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~15 minutes Merge Risk: ⚪ Minimal · up to The change contains validated build configuration and behavior-preserving C++ cleanups, with no established regression requiring resolution before merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 7.32% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 41 functions across 36 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
thepastaclaw
left a comment
thepastaclaw
left a comment
There was a problem hiding this comment.
⚠️ DEGRADED — Final validation — Phase 1 + Phase 2
⚠️ DEGRADED review. The primary review models were unavailable (gpt-6-astraunavailable: All credentials for model gpt-6-astra are cooling down (last error: usage_limit_reached: The usage limit has been reache), so this review ran on stand-in models:gpt-5.6-luna→muse-spark-1.3-contributor,gpt-5.6-sol→muse-spark-1.3-contributor,gpt-5.6-terra→muse-spark-1.3-contributor,gpt-6-astra→muse-spark-1.3-contributor. Both review phases and the independent verifiers still ran, but on weaker models, with Phase 1 capped athigheffort. Treat the verdict as provisional; a full-strength re-review will run on the next push once the primary models are back.
Backport stack for clang-tidy config and boost safe-mode handling is faithful with no behavioral or consensus impact. The only in-scope issue is a stale .clang-tidy comment invalidated by the safe-mode removal. A pre-existing benchmark index bug is noted separately as out-of-scope.
💬 1 nitpick(s)
Review provenance
Source: reviewer 1: gemini-3.8-flash-high (agent: phase1-reviewer, role: general); reviewer 2: gemini-3.8-flash-high (agent: phase1-reviewer, role: backport-reviewer); reviewer 3: gemini-3.8-flash-high (agent: phase1-reviewer, role: dash-core-commit-history); reviewer 4: muse-spark-1.3-contributor (standing in for gpt-6-astra) (agent: phase2-reviewer, role: backport-reviewer); reviewer 5: muse-spark-1.3-contributor (standing in for gpt-6-astra) (agent: phase2-reviewer, role: dash-core-commit-history); final verifier: muse-spark-1.3-contributor (standing in for gpt-6-astra) (agent: astra-verifier, role: final-verifier)
- Degraded mode:
gpt-6-astraunavailable: All credentials for model gpt-6-astra are cooling down (last error: usage_limit_reached: The usage limit has been reache (detected by probe, since 2026-09-18T05:22:01Z); stand-insgpt-5.6-luna→muse-spark-1.3-contributor,gpt-5.6-sol→muse-spark-1.3-contributor,gpt-5.6-terra→muse-spark-1.3-contributor,gpt-6-astra→muse-spark-1.3-contributor; Phase 1 effort capped athigh - Triage:
normalbymuse-spark-1.3-contributor(standing in forgpt-6-astra) (effort low) — Large cross-cutting but mechanical clang-tidy performance/style fixes across 40 files with no change to consensus, crypto, or funds-movement logic. - Phase 1 reviewers:
gemini-3.8-flash-high— general (completed, effort high); agentphase1-reviewer,gemini-3.8-flash-high— backport-reviewer (completed, effort high); agentphase1-reviewer,gemini-3.8-flash-high— dash-core-commit-history (completed, effort high); agentphase1-reviewer - Phase 1 model:
gemini-3.8-flash-high— antigravity quota: weekly 100% left, 5h 100% left - Fresh verifier:
muse-spark-1.3-contributor(standing in forgpt-6-astra) — final-verifier; agentastra-verifier - Phase 2 reviewers:
muse-spark-1.3-contributor(standing in forgpt-6-astra) — backport-reviewer (completed, effort high); agentphase2-reviewer,muse-spark-1.3-contributor(standing in forgpt-6-astra) — dash-core-commit-history (completed, effort high); agentphase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.
In `src/.clang-tidy`:
- [NITPICK] src/.clang-tidy:24-25: Stale comment still claims --enable-debug defines safe mode
Commit 47eabb8dc1 removes the automatic -DBOOST_MULTI_INDEX_ENABLE_SAFE_MODE from configure.ac for --enable-debug/--enable-fuzz; only ci/test/00_setup_env_native_qt5.sh now enables it explicitly. The comment above performance-for-range-copy.AllowedTypes still states --enable-debug defines the macro, which misleads future readers about when the safe_iterator allowlist entry applies.
Out-of-scope follow-up suggestions (1)
These are valid observations, but they are outside this PR's scope and should be handled in separate issues or author/maintainer-requested PRs rather than blocking this review.
- Loop index reset inside while-loop in BLS_Verify_BatchedParallel benchmark — In src/bench/bls.cpp,
size_t i = 0;is insidewhile (futures.size() < 10000), so it resets every iteration and the benchmark always verifies index 0. Pre-existing since file creation; this PR only changed make_pair to emplace_back, so it is outside this PR's scope.- Follow-up: Move
size_t i = 0;outside the while loop in a separate benchmark maintenance commit.
- Follow-up: Move
| # --enable-debug defines BOOST_MULTI_INDEX_ENABLE_SAFE_MODE, which makes | ||
| # mempool iterators non-trivially copyable in that configuration only |
There was a problem hiding this comment.
💬 Nitpick: Stale comment still claims --enable-debug defines safe mode
Commit 47eabb8 removes the automatic -DBOOST_MULTI_INDEX_ENABLE_SAFE_MODE from configure.ac for --enable-debug/--enable-fuzz; only ci/test/00_setup_env_native_qt5.sh now enables it explicitly. The comment above performance-for-range-copy.AllowedTypes still states --enable-debug defines the macro, which misleads future readers about when the safe_iterator allowlist entry applies.
| # --enable-debug defines BOOST_MULTI_INDEX_ENABLE_SAFE_MODE, which makes | |
| # mempool iterators non-trivially copyable in that configuration only | |
| # BOOST_MULTI_INDEX_ENABLE_SAFE_MODE (enabled explicitly in some CI jobs) makes | |
| # mempool iterators non-trivially copyable in that configuration only |
source: muse-spark-1.3-contributor (phase2-reviewer: backport-reviewer, dash-core-commit-history)
There was a problem hiding this comment.
valid issue ; had been done before including 27724 to the scope.
Cleaned up
There was a problem hiding this comment.
Resolved (re-reviewed at d51da968): Thanks for cleaning it up — verified src/.clang-tidy at this head no longer contains the stale comment or allowlist entry.
thepastaclaw
added
the
pastaclaw:commented
BACKPORT NOTE: LLVM/Clang 19 is already used everywhere ---- 8735e2c ci: use LLVM/Clang 17 in tidy job (fanquake) ce46b68 ci: use LLVM 17.0.2 in MSAN jobs (fanquake) Pull request description: Also update MSAN to use 17.0.2. Related to bitcoin#28465. ACKs for top commit: maflcko: lgtm ACK 8735e2c Tree-SHA512: 74452b95326cf065afe8332dc1b5b8e5ac12c8fe05c278a1cee017f87a7f7e0cdb8cac5e39d718c8ef587c8ee229bbaadd847df9f191313d41c5cdcab45e7c76 Co-authored-by: fanquake <fanquake@gmail.com>
BACKPORT NOTE: missing changes due to non-backported taproot yet ---- 636c986 ci: Bump `TIDY_LLVM_V` (Hennadii Stepanov) Pull request description: This PR switches to the latest [IWYU 0.22](https://github.com/include-what-you-use/include-what-you-use/releases/tag/0.22), which is compatible with Clang 18. ACKs for top commit: fanquake: ACK 636c986 Tree-SHA512: 78ce89244c5e487dd1be8b4bd2ca6f06d19b04b78289ebc21985110574053545dcce5eb622edf2bede2cf7bb58360170e976d30a4484a127d34dd17b1c604e9c Co-authored-by: fanquake <fanquake@gmail.com>
…bug mode 59c8944 build: disable boost multi index safe mode (willcl-ark) Pull request description: Fixes bitcoin#27586 Disable boost multi index safe mode by default when configuring with --enable-debug. This option can cause transactions to take a long time to be accepted into the mempool under certain conditions; iterator destruction takes O(n) time vs O(1) as they are stored in a singly linked list. See 27586 and the [boost docs](https://www.boost.org/doc/libs/1_58_0/boost/multi_index/detail/safe_mode.hpp) for more information. Re-enable it on the CI builds which previously had it enabled. Re-enable it on the msan fuzz task so that we have fuzz tasks testing with it enabled and disabled in this repo. ACKs for top commit: hebasto: ~ACK 59c8944~ fanquake: ACK 59c8944 Tree-SHA512: ed654f63dbebdd02e4414d1f81147d92a4d490dbb5a2e0376858e3129097645f3a2df45191d6b40c410a76e803b0d28796d1a01c1d2fd995b94e8b7eb3949027 Co-authored-by: fanquake <fanquake@gmail.com>
…heck names 06fc293 refactor: Remove duplication of clang-tidy's check names (Hennadii Stepanov) Pull request description: This PR removes duplication of `clang-tidy`'s check names. No behavior change. Split up from bitcoin#26642 as [requested](bitcoin#26642 (comment)). ACKs for top commit: fanquake: ACK 06fc293 Tree-SHA512: a21bef3d7d7201e14565b526af2eae7a90cf0f792803704a80a70a4c78f07ef2a2eef6a8dced80361efbf13291ecccb0977378b9532fc30970a2070426e4d82c Co-authored-by: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>
thepastaclaw
removed
the
pastaclaw:commented
thepastaclaw
left a comment
thepastaclaw
left a comment
There was a problem hiding this comment.
⚠️ DEGRADED — Re-review — Final validation — Phase 1 + Phase 2
⚠️ DEGRADED review. The primary review models were unavailable (gpt-6-astraunavailable: All credentials for model gpt-6-astra are cooling down (last error: usage_limit_reached: The usage limit has been reache), so this review ran on stand-in models:gpt-5.6-luna→muse-spark-1.3-contributor,gpt-5.6-sol→muse-spark-1.3-contributor,gpt-5.6-terra→muse-spark-1.3-contributor,gpt-6-astra→muse-spark-1.3-contributor. Both review phases and the independent verifiers still ran, but on weaker models, with Phase 1 capped athigheffort. Treat the verdict as provisional; a full-strength re-review will run on the next push once the primary models are back.
Backport of upstream clang-tidy changes with Dash-specific fixes is clean at this head; the stale safe-mode comment is gone and no new defects were found.
🔴 0 blocking | 🟡 0 suggestion(s) | 💬 0 nitpick(s)
Review provenance
Source: reviewer 1: gemini-3.8-flash-high (agent: phase1-reviewer, role: general); reviewer 2: gemini-3.8-flash-high (agent: phase1-reviewer, role: backport-reviewer); reviewer 3: gemini-3.8-flash-high (agent: phase1-reviewer, role: dash-core-commit-history); reviewer 4: muse-spark-1.3-contributor (standing in for gpt-6-astra) (agent: phase2-reviewer, role: general); reviewer 5: muse-spark-1.3-contributor (standing in for gpt-6-astra) (agent: phase2-reviewer, role: backport-reviewer); reviewer 6: muse-spark-1.3-contributor (standing in for gpt-6-astra) (agent: phase2-reviewer, role: dash-core-commit-history); reviewer 7: muse-spark-1.3-contributor (standing in for gpt-6-astra) (agent: phase2-reviewer, role: general); reviewer 8: muse-spark-1.3-contributor (standing in for gpt-6-astra) (agent: phase2-reviewer, role: backport-reviewer); reviewer 9: muse-spark-1.3-contributor (standing in for gpt-6-astra) (agent: phase2-reviewer, role: dash-core-commit-history); final verifier: muse-spark-1.3-contributor (standing in for gpt-6-astra) (agent: astra-verifier, role: final-verifier)
- Degraded mode:
gpt-6-astraunavailable: All credentials for model gpt-6-astra are cooling down (last error: usage_limit_reached: The usage limit has been reache (detected by probe, since 2026-09-18T05:22:01Z); stand-insgpt-5.6-luna→muse-spark-1.3-contributor,gpt-5.6-sol→muse-spark-1.3-contributor,gpt-5.6-terra→muse-spark-1.3-contributor,gpt-6-astra→muse-spark-1.3-contributor; Phase 1 effort capped athigh - Triage:
normalbymuse-spark-1.3-contributor(standing in forgpt-6-astra) (effort low) — Cross-cutting mechanical clang-tidy and build-config cleanups across 40 files with no consensus, funds-movement, or crypto behavior change. - Phase 1 reviewers:
gemini-3.8-flash-high— general (completed, effort high); agentphase1-reviewer,gemini-3.8-flash-high— backport-reviewer (completed, effort high); agentphase1-reviewer,gemini-3.8-flash-high— dash-core-commit-history (completed, effort high); agentphase1-reviewer - Phase 1 model:
gemini-3.8-flash-high— antigravity quota: weekly 100% left, 5h 100% left - Fresh final gate: an independent Phase-2 review ran after iterative findings were reconciled
- Fresh verifier:
muse-spark-1.3-contributor(standing in forgpt-6-astra) — final-verifier; agentastra-verifier - Phase 2 reviewers:
muse-spark-1.3-contributor(standing in forgpt-6-astra) — general (completed, effort high); agentphase2-reviewer,muse-spark-1.3-contributor(standing in forgpt-6-astra) — backport-reviewer (completed, effort high); agentphase2-reviewer,muse-spark-1.3-contributor(standing in forgpt-6-astra) — dash-core-commit-history (completed, effort high); agentphase2-reviewer,muse-spark-1.3-contributor(standing in forgpt-6-astra) — general (completed, effort high); agentphase2-reviewer,muse-spark-1.3-contributor(standing in forgpt-6-astra) — backport-reviewer (completed, effort high); agentphase2-reviewer,muse-spark-1.3-contributor(standing in forgpt-6-astra) — dash-core-commit-history (completed, effort high); agentphase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify the current code and confirm that no unresolved issues remain.
No unresolved findings remain from the prior review on this head.
thepastaclaw
removed
the
pastaclaw:commented
clang-tidy's performance-inefficient-vector-operation check flags these four loops. They became hard errors when #7693 backported bitcoin#26905, which replaced the explicit WarningsAsErrors allowlist in src/.clang-tidy with '*'. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
cf70026 lint: drop top-level const from ExpectedType's return type (pasta) b7ca886 lint: reserve vector capacity before push_back loops (pasta) Pull request description: ## Issue being fixed or feature implemented `develop` currently fails the `linux64_multiprocess-build / Build source` → "Run linters" step (`ci/dash/lint-tidy.sh`). #7693 backported bitcoin#26905, which replaced the explicit `WarningsAsErrors` allowlist in `src/.clang-tidy` with `WarningsAsErrors: '*'` (and added a matching `-warnings-as-errors=-clang-diagnostic-old-style-cast,-google-readability-casting` to `ci/dash/lint-tidy.sh` so the C-style-cast checks stay advisory). Every other enabled check is now a hard error, which promoted five pre-existing diagnostics from warnings to build failures: ``` llmq/quorumproofs.cpp:220:38: error: 'push_back' is called inside a loop [performance-inefficient-vector-operation] llmq/quorumproofs.cpp:405:43: error: 'push_back' is called inside a loop [performance-inefficient-vector-operation] rpc/quorums.cpp:1569:25: error: 'push_back' is called inside a loop [performance-inefficient-vector-operation] rpc/output_script.cpp:133:17: error: 'push_back' is called inside a loop [performance-inefficient-vector-operation] rpc/util.cpp:890:1: error: return type 'const std::optional<UniValue::VType>' is 'const'-qualified at the top level [readability-const-return-type] ``` The three quorum-proof sites came in with #7107; the two `rpc/` sites are older code that was only ever a warning before. The failure is not visible on PRs branched before #7693 merged, because CI checks out the PR head and therefore uses that branch's `.clang-tidy`. It shows up on any PR whose merge base is at or after #7693 — e.g. https://github.com/dashpay/dash/actions/runs/35530545254/job/106137443857. ## What was done? - `hashes.reserve(...)` / `leaves.reserve(...)` / `pubkeys.reserve(...)` ahead of the four flagged loops. The sizes are known up front in every case, so this is also a small genuine improvement. - Dropped the top-level `const` from `ExpectedType`'s by-value return type in `src/rpc/util.cpp`. It never conferred anything. No behavior changes. ## How Has This Been Tested? Reproduced the failure and verified the fix locally with clang-tidy 19 (same major version as CI's `LLVM_VERSION`), running the repo's `src/.clang-tidy` config against a compilation database for the four affected translation units: - Before: the two `llmq/quorumproofs.cpp` errors reproduce verbatim, including the `[performance-inefficient-vector-operation,-warnings-as-errors]` tag from CI. - After: zero `performance-inefficient-vector-operation` and zero `readability-const-return-type` diagnostics across all four files. All four translation units compile clean (`rpc/util.cpp`, `rpc/output_script.cpp`, `rpc/quorums.cpp`, `llmq/quorumproofs.cpp`) on an `aarch64-apple-darwin` depends build. Full CI will cover the rest. ## Breaking Changes None. ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) ACKs for top commit: knst: utACK cf70026 Tree-SHA512: f8394e31839ff2fdca2da7d515a29b7e28f252e457be8a55678098e79abfdc25d36aaa05cdf78bc8edd066c4ef354cc0d7cf814873e3e92dfa245c195a34b96c
… not_null precondition 00aabf5 fix: report the real source location for GetCreditPool's not_null precondition (UdjinM6) Pull request description: ## Issue being fixed or feature implemented `CCreditPoolManager::GetCreditPool()` records the wrong source location for its `not_null` precondition, so a failure reports a libc++ internal header instead of the code that produced the null pointer. 966f532, from #7693, changed `evo/creditpool.cpp` to call `emplace()` instead of `push()` on a `std::stack<gsl::not_null<const CBlockIndex*>>`, to satisfy clang-tidy's `modernize-use-emplace`. `gsl::not_null`'s converting constructor takes `nostd::source_location loc = nostd::source_location::current()` (`src/gsl/pointers.h:102`), backed by `__builtin_FILE()`, and forwards it to `Expects()`. A default argument is evaluated at the point of the call: `push()` constructs the `not_null` at the call site in `creditpool.cpp`, while `emplace()` forwards the raw pointer and constructs it inside libc++'s `std::construct_at`. That location is not merely stored, it is printed. `gsl::details::terminate()` (`src/gsl/assert.cpp:26-35`) writes `loc.file_name()`, `line()`, `column()` and `function_name()` to stderr and to `debug.log` via `LogPrintf` before calling `std::terminate()`, in release builds as well as debug ones. So a null `pprev` reaching `GetCreditPool` currently logs ERROR: error detected null not_null detected at .../__memory/construct_at.h:41:...:construct_at instead of naming `creditpool.cpp` and `GetCreditPool`. `modernize-use-emplace` is a false positive whenever the element type's constructor captures the caller's location this way. This was found while investigating a guix hash divergence on v24.0.0-rc.1 (dashpay/guix.sigs#190 vs #191), where the six macOS outputs differed between builders while all fifteen Linux, Windows and source outputs matched. On darwin the libc++ headers resolve through `-isysroot$(OSX_SDK)` (`depends/hosts/darwin.mk:75-81`), so the captured path is inside the macOS SDK, and `contrib/guix/guix-build:452` shares the SDK into the container at the builder's own host path — `--share="$SDK_PATH"`, with no `=/target` remap, unlike `--share="$PWD"=/dash`. Worth being precise about why this has not bitten earlier releases: the default `SDK_PATH` is repo-relative — `depends/Makefile:34` (`SDK_PATH ?= $(BASEDIR)/SDKs`), `contrib/containers/guix/scripts/setup-sdk:11`, `contrib/containers/guix/scripts/guix-start:13` — so it resolves to `/dash/depends/SDKs/…` inside the container for every builder regardless of where their checkout lives. The embedded path was a constant, not a variable. It only becomes builder-specific when a builder overrides `SDK_PATH` to a location outside the checkout, which is what happened for rc.1. ## What was done? Reverted the `emplace()` to `push()`, with a `NOLINT(modernize-use-emplace)` and a comment recording why, so the tidy rewrite is not reapplied. `gsl::not_null` is a thin wrapper over a raw pointer, so both forms emit the same store; `emplace()` bought nothing here beyond silencing the check. Deliberately out of scope: `SDK_PATH` is the only container share whose value reaches the compiler command line and is not remapped to a fixed path. `SOURCES_PATH` and `BASE_CACHE` are used solely for source and package-cache storage (`depends/funcs.mk:59,74,208`, `depends/Makefile:268`), while `$PWD` and `DISTSRC_BASE` are remapped precisely because they do reach it. Normalising the SDK mount is a separate guix fix and belongs in its own PR rather than riding along here. ## How Has This Been Tested? No test was added. The behaviour is a property of the emitted binary, and the only way to observe the logged location is to make the precondition fail, which requires a null `pprev` — a state that would mean the block index is already corrupt. Verified by compiling a translation unit that includes the real `src/gsl/pointers.h` and mirrors `GetCreditPool`'s stack, then inspecting the object file for the captured location: | variant | location recorded in the object file | |---|---| | `emplace()` (current `develop`) | `<sdk>/usr/include/c++/v1/__memory/construct_at.h` | | `push()` (this PR) | the call site in `creditpool.cpp` | Also audited the tree for the same pattern elsewhere. `gsl::not_null` appears in 145 places outside `src/gsl`, all parameters or locals except two stored ones: the stack fixed here, and `UtilParameters::m_base_index` (`src/llmq/utils.h:36`). Every `UtilParameters` construction site is braced aggregate initialisation at the call site, so none forwards a raw pointer through a std header. `src/gsl` is also the only user of `nostd::source_location` in the tree. `test/lint/lint-whitespace.py` passes. Not built or run through `make check` locally; CI covers both. ## Breaking Changes None. No consensus, P2P, RPC, wallet or on-disk behaviour changes. The only difference is the file, line and function reported if the `not_null` precondition in `GetCreditPool` ever fires. ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone 🤖 Generated with [Claude Code](https://claude.com/claude-code) ACKs for top commit: knst: utACK 00aabf5 Tree-SHA512: 8e070e5489b922c5520e35f494022174a9d1c1ecf157e65afd39ec8471d2acb1059954f86b32416728c8b67b2441493a8726285016806e083344b3e2da8a01c2
3 participants
Issue being fixed or feature implemented
Just backporting bare bitcoin#26095 doesn't work, due to newer version of clang, multiple dash specific code.
What was done?
Backports:
clang-tidy's check names bitcoin/bitcoin#26905TIDY_LLVM_Vbitcoin/bitcoin#29659Multiple fixes for dash code:
How Has This Been Tested?
See CI run
Breaking Changes
Debug builds doesn't use anymore extra asserts for multi-index maps.
Checklist: