Skip to content

fix: stop fish completion from re-running the typed dash-cli command #7783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PastaPastaPasta merged 2 commits into from
Oct 4, 2026
Merged

fix: stop fish completion from re-running the typed dash-cli command #7783

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff98899
fix(contrib): stop fish completion from re-running the typed dash-cli…
PastaPastaPasta Oct 4, 2026
5339d4f
refactor(contrib): match dash-cli connection options by prefix in fis…
PastaPastaPasta Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions contrib/completions/fish/dash-cli.fish
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,20 @@ function __fish_dash_cli_get_commands_helper
return
end

# Strip help cmd from token to avoid duplication errors
set --local cmd (string match --invert --regex -- '^help$' $cmd)
# Strip -stdin* options to avoid waiting for input while we fetch completions
# TODO: this appears to be broken when run as tab completion (requires ctrl+c to exit)
set --local cmd (string match --invert --regex -- '^-stdin.*$' $cmd)
# Only keep the connection options given before the RPC command. Never pass
# on the typed command or its arguments: they would be executed on every Tab
# (e.g. `sendtoaddress <address> <amount> <Tab>` would send funds).
# -rpcwait* is dropped so Tab doesn't hang while the node is down.
set --local base $cmd[1]
for arg in $cmd[2..-1]
string match --quiet --regex -- '^-' $arg; or break
if string match --quiet --regex -- '^--?(conf|datadir|testnet|regtest|devnet|chain|rpc(?!wait))' $arg
set --append base $arg
end
end

# Match, format and return commands
for command in ($cmd help 2>&1 | string match --invert -r '^\=\=.*' | string match --invert -r '^\\s*$')
for command in ($base help 2>&1 | string match --invert -r '^\=\=.*' | string match --invert -r '^\\s*$')
echo $command
end
end
Expand Down Expand Up @@ -60,9 +66,9 @@ function __fish_dash_cli_get_options
set --local options

if set -q _flag_nofiles
set --append options ($cmd -help 2>&1 | string match -r '^ -.*' | string replace -r ' -' '-' | string replace -r '=.*' '=' | string match --invert -r '^.*=$')
set --append options ($cmd[1] -help 2>&1 | string match -r '^ -.*' | string replace -r ' -' '-' | string replace -r '=.*' '=' | string match --invert -r '^.*=$')
else
set --append options ($cmd -help 2>&1 | string match -r '^ -.*' | string replace -r ' -' '-' | string replace -r '=.*' '=' | string match -r '^.*=$')
set --append options ($cmd[1] -help 2>&1 | string match -r '^ -.*' | string replace -r ' -' '-' | string replace -r '=.*' '=' | string match -r '^.*=$')
end

for option in $options
Expand Down
Loading