Skip to content

fix: nil address check#540

Merged
Syn-McJ merged 1 commit into
dashpay:developfrom
Syn-McJ:fix/confirm-request-crash
Apr 25, 2024
Merged

fix: nil address check#540
Syn-McJ merged 1 commit into
dashpay:developfrom
Syn-McJ:fix/confirm-request-crash

Conversation

@Syn-McJ

@Syn-McJ Syn-McJ commented Apr 23, 2024

Copy link
Copy Markdown
Member

What was done?

Check if the address is nil before calling transactionCreationCompletion to avoid a crash.

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf April 23, 2024 11:24
@Syn-McJ Syn-McJ self-assigned this Apr 23, 2024
@Syn-McJ Syn-McJ changed the base branch from master to develop April 23, 2024 11:24

@pankcuf pankcuf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syn-McJ Syn-McJ merged commit 49b6db2 into dashpay:develop Apr 25, 2024
@Syn-McJ Syn-McJ deleted the fix/confirm-request-crash branch April 25, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants