Skip to content

Release: v2.5.4 #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pankcuf merged 39 commits into from
Nov 8, 2024
Merged

Release: v2.5.4 #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
ed19e92
fix: we should store default currency initially
pankcuf Jul 18, 2024
4db59f7
chore: bump up protocol version 70233
pankcuf Aug 7, 2024
4a5b845
Merge pull request #557 from dashpay/feat/core-v0.21.2
pankcuf Aug 7, 2024
b5dbfee
Merge pull request #553 from dashpay/fix/default-currency
pankcuf Aug 13, 2024
5f60be6
chore: disable max proto version check
pankcuf Sep 24, 2024
e9152bc
Merge pull request #569 from dashpay/feat/disable-max-protocol-version
pankcuf Oct 1, 2024
0f50cd8
fix: switch to upload-artifact v3
ogabrielides Oct 3, 2024
7c7e446
bumped to v4
ogabrielides Oct 3, 2024
fda5d9d
fix: xcode 16 build
ogabrielides Oct 1, 2024
413ea3f
build fix for macOS NetworkInfo build
ogabrielides Oct 9, 2024
5a9e2e6
bumped DashSharedCore
ogabrielides Oct 9, 2024
de1a18e
linker fixes
ogabrielides Oct 9, 2024
f17c047
Podfile adjustements
ogabrielides Oct 9, 2024
246cbef
chore: bumped dash-shared-core
ogabrielides Oct 10, 2024
0898056
added clear deps task
ogabrielides Oct 10, 2024
ba7ea1f
moved clear deps into build workflow and updated checkout acctions
ogabrielides Oct 10, 2024
c6cd896
bumped checkout actions to v3
ogabrielides Oct 10, 2024
40807aa
clear deps in network as well
ogabrielides Oct 10, 2024
9b0a9eb
Added -allowProvisioningUpdates
ogabrielides Oct 10, 2024
003da1b
Adjusted Podfile.lock
ogabrielides Oct 10, 2024
6e19078
disable signing in CI
ogabrielides Oct 10, 2024
34d86bb
disable signing in all flows
ogabrielides Oct 10, 2024
2229d2d
test adhoc e2e
ogabrielides Oct 10, 2024
db4f77a
test automatic sign
ogabrielides Oct 10, 2024
c23adcb
ad-hoc signing
ogabrielides Oct 10, 2024
b092395
sign to run locally
ogabrielides Oct 10, 2024
6c12bcb
manual
ogabrielides Oct 10, 2024
56b2623
test
ogabrielides Oct 10, 2024
2aa4e33
Merge pull request #572 from ogabrielides/github_workflow_network_fix
pankcuf Nov 4, 2024
399b88c
feat: asset lock/unlock tx
pankcuf Nov 4, 2024
cbae8e9
fix: tx hashing + add simple unit test
pankcuf Nov 5, 2024
624e00f
Merge pull request #578 from dashpay/feat/asset-unlock
pankcuf Nov 6, 2024
bd8595d
chore: bump up DashSharedCore to 0.4.19
pankcuf Nov 6, 2024
881566f
Merge pull request #579 from dashpay/chore/disable-dash-shared-core-d…
pankcuf Nov 7, 2024
99cdcc8
Update DashSync/shared/Models/Transactions/Base/DSAssetLockTransaction.h
pankcuf Nov 8, 2024
d82ad57
Update DashSync/shared/Models/Entities/DSAssetLockTransactionEntity+C…
pankcuf Nov 8, 2024
928aeef
Update DashSync/shared/Models/Wallet/DSSpecialTransactionsWalletHolder.m
pankcuf Nov 8, 2024
f494e28
chore: revert coderabbit stuff
pankcuf Nov 8, 2024
1828f75
chore: coderabbitai fix
pankcuf Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
name: Continuous Integration

on:
push:
branches:
Expand All @@ -10,7 +9,6 @@ on:
branches:
- master
- develop

jobs:
build:
name: Build
Expand All @@ -20,7 +18,7 @@ jobs:
run: |
brew install automake
- name: Checkout DashSync
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
path: dashsync
submodules: recursive
Expand Down Expand Up @@ -48,13 +46,17 @@ jobs:
xcode-version: '15.4'
- name: Rustup add targets
run: rustup target add aarch64-apple-ios x86_64-apple-ios aarch64-apple-ios-sim
- name: Dependencies
- name: Build dependencies
working-directory: ./dashsync/Example
run: pod install --repo-update --verbose
- name: Build
- name: Build for iOS Simulator (without code signing)
working-directory: ./dashsync/Example
env:
scheme: ${{ 'default' }}
scheme: ${{ 'DashSync-Example' }}
platform: ${{ 'iOS Simulator' }}
run: |
xcodebuild build -scheme "DashSync-Example" -workspace "DashSync.xcworkspace" -destination "platform=$platform,name=iPhone 13"
xcodebuild build \
-scheme "DashSync-Example" \
-workspace "DashSync.xcworkspace" \
-destination "platform=$platform,name=iPhone 13" \
Comment thread
pankcuf marked this conversation as resolved.
CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGN_ENTITLEMENTS="" CODE_SIGNING_ALLOWED=NO
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
run: |
brew install automake
- name: Checkout DashSync
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
path: dashsync
submodules: recursive
Expand Down
20 changes: 14 additions & 6 deletions .github/workflows/e2eTestsTestnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
run: |
brew install automake
- name: Checkout DashSync
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
path: dashsync
submodules: recursive
Expand Down Expand Up @@ -48,17 +48,25 @@ jobs:
- name: Dependencies
working-directory: ./dashsync/Example
run: pod install --repo-update
- name: Build
- name: Build for testing (with ad-hoc code signing)
working-directory: ./dashsync/Example
env:
scheme: ${{ 'default' }}
scheme: ${{ 'DashSync-Example' }}
platform: ${{ 'iOS Simulator' }}
run: |
xcodebuild build-for-testing -scheme "DashSync-Example" -workspace "DashSync.xcworkspace" -destination "platform=$platform,name=iPhone 13"
xcodebuild build-for-testing \
-scheme "DashSync-Example" \
-workspace "DashSync.xcworkspace" \
-destination "platform=$platform,name=iPhone 13" \
CODE_SIGN_IDENTITY="-" CODE_SIGNING_REQUIRED=YES CODE_SIGNING_ALLOWED=YES
- name: Test Syncing Chain
working-directory: ./dashsync/Example
env:
scheme: ${{ 'default' }}
scheme: ${{ 'DashSync-Example' }}
platform: ${{ 'iOS Simulator' }}
run: |
xcodebuild test-without-building -scheme "DashSync-Example" -workspace "DashSync.xcworkspace" -destination "platform=$platform,name=iPhone 13" -testPlan TestnetE2ETests
xcodebuild test-without-building \
-scheme "DashSync-Example" \
-workspace "DashSync.xcworkspace" \
-destination "platform=$platform,name=iPhone 13" \
-testPlan TestnetE2ETests
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
run: |
brew install automake
- name: Checkout DashSync
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
path: dashsync
submodules: recursive
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/network.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
run: |
brew install automake
- name: Checkout DashSync
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
path: dashsync
submodules: recursive
Expand All @@ -44,7 +44,7 @@ jobs:
run: cargo install cargo-lipo
- name: Rustup add targets
run: rustup target add x86_64-apple-darwin
- name: Dependencies
- name: Build Dependencies
working-directory: ./dashsync/Example
run: pod install --repo-update
- name: Cache network info build
Expand All @@ -71,7 +71,9 @@ jobs:
run: |
./NetworkInfo -outputDir ~/
- name: Archive network ping results
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4 # Updated to v4
with:
name: testnet-network-report
path: ~/networkHealth.json
retention-days: 30
compression-level: 6 # Default, adjust as needed
2 changes: 1 addition & 1 deletion .github/workflows/syncTestMainnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
run: |
brew install automake
- name: Checkout DashSync
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
path: dashsync
submodules: recursive
Expand Down
21 changes: 15 additions & 6 deletions .github/workflows/syncTestTestnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
git lfs ls-files -l | cut -d' ' -f1 | sort > .lfs-assets-id
working-directory: ./dashsync
- name: Restore LFS cache
uses: actions/cache@v2
uses: actions/cache@v3
id: lfs-cache
with:
path: dashsync/.git/lfs
Expand All @@ -48,17 +48,26 @@ jobs:
- name: Dependencies
working-directory: ./dashsync/Example
run: pod install --repo-update
- name: Build
- name: Build for testing (without code signing)
working-directory: ./dashsync/Example
env:
scheme: ${{ 'default' }}
scheme: ${{ 'DashSync-Example' }}
platform: ${{ 'iOS Simulator' }}
run: |
xcodebuild build-for-testing -scheme "DashSync-Example" -workspace "DashSync.xcworkspace" -destination "platform=$platform,name=iPhone 13"
xcodebuild build-for-testing \
-scheme "DashSync-Example" \
-workspace "DashSync.xcworkspace" \
-destination "platform=$platform,name=iPhone 13" \
CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGN_ENTITLEMENTS="" CODE_SIGNING_ALLOWED=NO
Comment thread
pankcuf marked this conversation as resolved.
- name: Test Syncing Chain
working-directory: ./dashsync/Example
env:
scheme: ${{ 'default' }}
scheme: ${{ 'DashSync-Example' }}
platform: ${{ 'iOS Simulator' }}
run: |
xcodebuild test-without-building -scheme "DashSync-Example" -workspace "DashSync.xcworkspace" -destination "platform=$platform,name=iPhone 13" -testPlan TestnetSyncTests
xcodebuild test-without-building \
-scheme "DashSync-Example" \
-workspace "DashSync.xcworkspace" \
-destination "platform=$platform,name=iPhone 13" \
-testPlan TestnetSyncTests \
CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGN_ENTITLEMENTS="" CODE_SIGNING_ALLOWED=NO
Comment thread
pankcuf marked this conversation as resolved.
Loading