Skip to content

refactor: use library for feature version #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 2 commits into from
Jul 10, 2024
Merged

refactor: use library for feature version #1938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fd07d7
refactor: use library for feature version
QuantumExplorer Jul 9, 2024
adf677e
chore: update rs-platform-version description
QuantumExplorer Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion packages/rs-platform-version/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
[package]
name = "platform-version"
authors = ["Samuel Westrich <sam@dash.org>"]
description = "Bincode based serialization and deserialization"
description = "Versioning library for Platform"
version = "1.0.0-dev.16"
edition = "2021"
rust-version = "1.76"
license = "MIT"

[dependencies]
thiserror = { version = "1.0.59" }
versioned-feature-core = { git = "https://github.com/dashpay/versioned-feature-core", version = "1.0.0" }

[features]
mock-versions = []
17 changes: 1 addition & 16 deletions packages/rs-platform-version/src/version/protocol_version.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,22 +14,7 @@ use crate::version::v1::PLATFORM_V1;
#[cfg(feature = "mock-versions")]
use std::sync::OnceLock;

pub type FeatureVersion = u16;
pub type OptionalFeatureVersion = Option<u16>; //This is a feature that didn't always exist

#[derive(Clone, Debug, Default)]
pub struct FeatureVersionBounds {
pub min_version: FeatureVersion,
pub max_version: FeatureVersion,
pub default_current_version: FeatureVersion,
}

impl FeatureVersionBounds {
/// Will get a protocol error if the version is unknown
pub fn check_version(&self, version: FeatureVersion) -> bool {
version >= self.min_version && version <= self.max_version
}
}
pub use versioned_feature_core::*;

#[derive(Clone, Debug, Default)]
pub struct AbciStructureVersion {
Expand Down