Skip to content

ci: re-pin PR Hygiene so its runs queue instead of cancelling - #4774

Merged
shumkov merged 1 commit into
v4.3-devfrom
chore/pr-hygiene-queue-v4.3-dev
Sep 16, 2026
Merged

shumkov merged 1 commit into
v4.3-devfrom
chore/pr-hygiene-queue-v4.3-dev

Conversation

@shumkov

@shumkov shumkov commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Re-pins the shared review workflow onto dashpay/stale_prs_are_bad#26 and #27.

Runs queue instead of cancelling. A concurrency group holds one pending run and cancels it when the next event arrives, so three events on one pull request inside a run's duration cancelled the middle one — and a cancelled run renders as a failed check. That was 1494 of 6556 runs over five days, and it is why pull requests have been going red. concurrency.queue: max lets them wait in arrival order instead; nothing is cancelled, and runs for one pull request stay serialised.

One duplicated comment no longer freezes an author's queue. Two runs reconciling the same pull request at once could each open a controller state comment, after which every later run refused to read that pull request's history — and the handler for that refusal puts an error status on every open pull request of that author. Hourly, until someone deleted a comment by hand. The oldest record now wins; nothing is deleted.

Also: a refused label or reviewer request is reported and skipped rather than aborting the run.

Verified on dash-evo-tool before this round: concurrency.queue is accepted in a called workflow and the run succeeds.

No change to who may approve, when a pull request is ready, or what blocks it. The only line that differs here is the pinned engine revision.

🤖 Generated with Claude Code

A concurrency group holds one pending run and cancels it when the next event
arrives, so a burst of events on one pull request cancelled the middle ones and
a cancelled run renders as a failed check. Runs now queue in arrival order.

dashpay/stale_prs_are_bad#26 and #27 landed as b378d1d7f9c3949a5f73822362ca02d251ab8141.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: d3702dec-9c69-4269-9b73-1dca50642ba8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added this to the v4.3.0 milestone Sep 16, 2026
@shumkov
shumkov merged commit bbddd4f into v4.3-dev Sep 16, 2026
8 checks passed
@shumkov
shumkov deleted the chore/pr-hygiene-queue-v4.3-dev branch September 16, 2026 05:58
@thepastaclaw

Copy link
Copy Markdown
Collaborator

🕓 Review not started yet because the new head is waiting for the 30-minute push debounce.

  • Request normal review — click when the PR is ready for review.
  • Request priority review — click to move this review to the front of the queue.

Commit 287a7df. Normal review starts when eligible; priority review starts as soon as a slot is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants