[kwvg]

Additional Information

• Upstream resolved rust-bitcoin#7106 with rust-bitcoin#7103, which allowed reverting base-sdk#73 (itself a workaround to deal with teething issues with vendoring caused by the awkward revision pinning due to stepping around bitcoin-crypto relying on a yanked crate)

  • Revision pinning has blocked publishing to crates.io (as noted in rust-dashcore#1223) and now with this cleared, Base SDK was able to issue new releases with base-sdk#127.

• This pull request also mirrors base-sdk#127@eb65027b to prevent version tearing, as a guardrail on top of rust-bitcoin#1108

PR Hygiene · 5b4be7f

• Bots — coderabbitai ✓
• Self-review — posted; again after any push
• Build green
• Approvals
  • files with no dedicated owner (Cargo.toml, crypto/Cargo.toml, crypto/src/lib.rs and 1 more) — QuantumExplorer or ZocoLini or xdustinface

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

Summary by CodeRabbit

• Chores
  • Updated underlying components used for cryptocurrency support. The existing public access point for Base58 functionality remains available.
  • Updated project checks for consistency across supported components. These changes do not alter end-user features or behavior.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

Workspace dependencies for base-sdk and rust-bitcoin now use crates.io versions. The crypto crate exposes base58ck through its base58 re-export. Cargo deny settings now reject multiple versions of specified crates and add scoped skips.

Changes: Dependency Migration

Layer / File(s)	Summary
Crates.io dependency migration and version policy Cargo.toml, crypto/Cargo.toml, crypto/src/lib.rs, deny.toml	Workspace dependencies move from pinned Git revisions to crates.io versions. The crypto crate adds base58ck and uses it for the public base58 re-export. deny.toml rejects multiple versions of the listed crates and adds scoped skips.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other · Severity of issue fixed: Medium

Suggested reviewers: zocolini, xdustinface

Merge Risk: Low · up to 5b4be

Large fixed-array Base58Check payloads that previously decoded can now fail. The change is mergeable with awareness of this compatibility limit.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title identifies the switch to crates.io and the version checks for base-sdk and rust-bitcoin. It is long, but it describes the main changes.
Linked Issues check		Issue [#7106] is closed and provides historical context only. No active linked-issue coding requirements apply.
Out of Scope Changes check		The dependency updates, base58ck re-export, and version-tearing guards support the PR's stated dependency migration and guardrail objectives. Issue [#7106] provides historical context.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (3 skipped: 3 unsupported.)

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

Recent review info

Run configuration

• Source mode: Auto
• Repository: dashpay/rust-dashcore
• Branch: dev
• File: .coderabbit.yaml
• Commit: f5d2b9b
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: f18c1ba6-304d-468d-86e8-e220cc5dd0fe

Commits

Reviewing files that changed from the base of the PR and between f5d2b9b and 5b4be7f.

Files selected for processing: 4

• Cargo.toml
• crypto/Cargo.toml
• crypto/src/lib.rs
• deny.toml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

[github-actions]

Waiting for bot review — coderabbitai not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.28%. Comparing base (f5d2b9b) to head (5b4be7f).

Additional details and impacted files

@@           Coverage Diff           @@
##              dev    #1360   +/-   ##
=======================================
  Coverage   85.28%   85.28%           
=======================================
  Files         268      268           
  Lines       68754    68754           
=======================================
  Hits        58635    58635           
  Misses      10119    10119           

Flag	Coverage Δ
core	82.42% <ø> (ø)
rpc	52.10% <ø> (ø)
spv	94.06% <ø> (ø)
wallet	83.39% <ø> (ø)
see 3 files with indirect coverage changes

[github-actions]

Bots are done — your move: post /self-reviewed.
Full checklist in the description.

[kwvg]

/self-reviewed

[github-actions]

Ready for review — files with no dedicated owner: QuantumExplorer or ZocoLini or xdustinface.
Full checklist in the description.