Skip to content

feat: add x11 hash algorithm to compute a block-hash from a header - #20

Merged
shotonoff merged 22 commits into
upgradefrom
feat/x11-hash-for-block-hash
Jun 2, 2023
Merged

shotonoff merged 22 commits into
upgradefrom
feat/x11-hash-for-block-hash

Conversation

@shotonoff

Copy link
Copy Markdown
Contributor

No description provided.

@shotonoff
shotonoff changed the base branch from master to upgrade May 26, 2023 14:12
Comment thread dash/src/blockdata/transaction/mod.rs Outdated
Comment thread dash/src/blockdata/transaction/special_transaction/coinbase.rs
/// inputs_hash(32) +
/// payload_sig(VarInt(payload_sig_len).len() + payload_sig_len)
pub fn size(&self) -> usize {
let mut size = 2 + 2 + 2 + 32 + 4 + 16 + 2 + 20 + 48 + 20 + 2 + 32; // 182 bytes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering why we do it like that and why we cannot use type's sizes

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because:

  1. some structures have vector(s) byte
  2. the size is needed to compute block weight

@shotonoff
shotonoff force-pushed the feat/x11-hash-for-block-hash branch from 6a9fca6 to 1f0cd6e Compare June 2, 2023 14:06
@shotonoff
shotonoff merged commit b7b2a0d into upgrade Jun 2, 2023
@shotonoff
shotonoff deleted the feat/x11-hash-for-block-hash branch June 2, 2023 15:25
QuantumExplorer added a commit that referenced this pull request Jun 12, 2023
* added ProTxHash

* added ProTxHash

* added ProTxHash

* added ProTxHash

* added ProTxHash

* added ProTxHash

* removed ProTxHash

* upgrade part 1

* another round of improvements

* more work

* fix: upgrade-v2 (#15)

* fix: some modification to make a code compilable

* backport: backporting coinbase payload accroding to changes in Core v20 (#22)

* chore: upgrade fuzz toolchain to 1.65

* feat: add x11 hash algorithm to compute a block-hash from a header (#20)

* feat: add hash_x11
* chore: upgrade fuzz toolchain to 1.65

* feat: backport instant-lock feature (#23)

* chore: disable cross compiling from CI pipeline

* chore: disable dash_deserialize_prefilled_transaction and dash_deserialize_psbt to pass CI tests

* chore: disable deserialize_prefilled_transaction and deserialize_psbt

---------

Co-authored-by: Quantum Explorer <quantum@dash.org>
shumkov pushed a commit that referenced this pull request Feb 28, 2025
fix: support Option<u32> for "pose_revived_height" field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants