Repository navigation
issues 8 - #267
Merged
Merged
issues 8#267
Conversation
AsrPhraseFinetuneOption and OSSUtils requests sent x-dashscope-sdk-client without the module segment; they now report "audio" and "utils" respectively. Add unit and wire-level tests locking the client/version[/module] + session-id header contract.
The contract is exactly x-dashscope-sdk-client (client/version[/module]) plus x-dashscope-sdk-session-id. Drop references to the retired x-dashscope-sdk-version/x-dashscope-sdk-module names; absence of any other x-dashscope-sdk-* header is now guarded by prefix scanning, both at the builder level and on the wire.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x-dashscope-sdk-client的 module 段遗漏：AsrPhraseFinetuneOption.getModule()返回"audio"；OSSUtils改走 9 参buildHttpHeaders传入"utils"，两者现在发出完整的client/version/module格式。TestDashScopeHeaders（14 个）+ MockWebServer 线级测试TestSdkClientTrackingHeader（4 个），锁定client/version[/module]合并格式、仅发 sdk-client + session-id 两个头（sdk-version/sdk-module 不存在）、自定义头覆盖、DASHSCOPE_DISABLE_SDK_HEADERS关闭开关、各 ServiceOption 的 module 映射。Test plan
mvn test -Dtest=TestDashScopeHeaders,TestSdkClientTrackingHeader— 18/18 通过lint.shclean