Skip to content

[test coverage] decide_workers never returns None in the unit tests #6254

Open

Description

@crusaderky

if self.validate:
assert ws is None or isinstance(ws, WorkerState), (
type(ws),
ws,
)
assert ws.address in self.workers

This bug makes everything crash with AttributeError whenever the top-level function decide_workers returns None.
However, no unit test (where validate=True) catches this.

Activity

  1. added
    testsUnit tests and/or continuous integration
    on May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testsUnit tests and/or continuous integration

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions