Skip to content

CrossFilter worker widget is broken and untested #6303

Closed

Description

@crusaderky

Dask dashboard -> info -> open any worker -> CrossFilter
Start any computation

Nothing shows up on the widget. On the worker log you can read:

2022-05-08 23:16:33,220 - bokeh.util.tornado - ERROR - Error thrown from periodic callback:
2022-05-08 23:16:33,221 - bokeh.util.tornado - ERROR - Traceback (most recent call last):
  File "/home/crusaderky/miniconda3/envs/distributed39/lib/python3.9/site-packages/distributed/utils.py", line 765, in wrapper
    return func(*args, **kwargs)
  File "/home/crusaderky/miniconda3/envs/distributed39/lib/python3.9/site-packages/distributed/dashboard/components/worker.py", line 360, in update
    d = self.process_msg(msg)
  File "/home/crusaderky/miniconda3/envs/distributed39/lib/python3.9/site-packages/distributed/dashboard/components/worker.py", line 413, in process_msg
    typ = self.worker.types.get(status_key, object).__name__
AttributeError: 'Worker' object has no attribute 'types'

test_worker_bokeh.py::test_basic is supposed to test it, but due to subtle timings reasons it never invokes the update() method.

Activity

  1. quasiben commented on May 10, 2022

    @quasiben
    Member

    I'm not sure I've ever used the crossfilter. Have you found it useful ?

  2. crusaderky commented on May 10, 2022

    @crusaderky
    CollaboratorAuthor

    I personally didn't know it existed. I stumbled on it by accident.

  3. crusaderky commented on May 31, 2022

    @crusaderky
    CollaboratorAuthor

    After conversation with @mrocklin, we agreed to remove the widget completely, at least for the time being.

  4. self-assigned this
    on Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions