Skip to content

flaky test_quiet_close_process[False] #6582

Closed

Description

@gjoseph92

It's possible this has already been fixed in #6567. If we don't see it again for a couple weeks, let's close this. However, I have a feeling the TimeoutError not being retrieved is some other problem.

_______________________ test_quiet_close_process[False] ________________________
processes = False
tmp_path = PosixPath('/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/test_quiet_close_process_False0')
@pytest.mark.parametrize("processes", [True, False])
deftest_quiet_close_process(processes, tmp_path):
withopen(tmp_path / "script.py", mode="w") as f:
            f.write(client_script % processes)
        proc = subprocess.Popen(
            [sys.executable, tmp_path / "script.py"],
            stdout=subprocess.PIPE,
            stderr=subprocess.PIPE,
        )
        out, err = proc.communicate(timeout=10)
assertnot out
>       assertnot err
E       assert not b"Future exception was never retrieved\nfuture: <Future finished exception=TimeoutError('Timeout')>\ntornado.util.TimeoutError: Timeout\n"
distributed/tests/test_client.py:7529: AssertionError

https://github.com/dask/distributed/runs/6893247153?check_suite_focus=true#step:11:1378

Activity

  1. crusaderky commented on Jun 17, 2022

    @crusaderky
    Collaborator

    I'm now getting a different one:

      assert not out
    

    E AssertionError: assert not b'/Users/runner/miniconda3/envs/dask-distributed/lib/python3.10/contextlib.py:142: UserWarning: Creating scratch directories is taking a surprisingly long time. This is often due to running workers on a network file system. Consider specifying a local-directory to point workers to write scratch data to a local disk.\n next(self.gen)\n'

  2. gjoseph92 commented on Jul 19, 2022

    @gjoseph92
    CollaboratorAuthor
  3. fjetter commented on Aug 11, 2022

    @fjetter
    Member

    This is possibly closed by #6847

  4. gjoseph92 commented on Aug 24, 2022

    @gjoseph92
    CollaboratorAuthor
  5. crusaderky commented on Aug 25, 2022

    @crusaderky
    Collaborator

    The stdout message is now different from before though:

    
    >       assert not out
    E       assert not b"Future exception was never retrieved\nfuture: <Future finished exception=TimeoutError('Timeout')>\ntornado.util.TimeoutError: Timeout\n"
    

    This test is a canary for all unrelated cleanup and performance problems.
    I'm going to build a blacklist of common warnings into it.

  6. self-assigned this
    on Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

flaky testIntermittent failures on CI.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions