Skip to content

WIP Remove pytest asyncio pinning - #4858

Closed
fjetter wants to merge 2 commits into
dask:mainfrom
fjetter:relieve_pytest_asyncio_pinning
Closed

fjetter wants to merge 2 commits into
dask:mainfrom
fjetter:relieve_pytest_asyncio_pinning

Conversation

@fjetter

@fjetter fjetter commented May 27, 2021

Copy link
Copy Markdown
Member

This removes the pinning for pytest-asyncio

Nice side benefit is that we'll wrap all asyncio marked tests automagically with our clean ctx manager.

@fjetter fjetter changed the title WIP Relieve pytest asyncio pinning WIP Remove pytest asyncio pinning May 27, 2021
@QuLogic

QuLogic commented Mar 6, 2022

Copy link
Copy Markdown
Contributor

Is there some possibility of moving this forward soon?

@fjetter

fjetter commented Mar 7, 2022

Copy link
Copy Markdown
Member Author

Is there some possibility of moving this forward soon?

It's unlikely that I'll find time for this soon. If you are up for it, feel free to have a look

@graingert

Copy link
Copy Markdown
Member

might be better to use @gen_test instead of @pytest.mark.asyncio and drop the dep on pytest-asyncio

@fjetter

fjetter commented Mar 7, 2022

Copy link
Copy Markdown
Member Author

might be better to use @gen_test instead of @pytest.mark.asyncio and drop the dep on pytest-asyncio

I'm open for this as well. In the past, usage of pytest-asyncio was useful because we could more easily use pytest fixtures. gen_test does support this by now so I don't see a strong reason for a continued usage of pytest-asyncio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants