Repository navigation
Ensure heartbeats after cancelation do not raise KeyErrors - #5053
Merged
Merged
Conversation
Member
|
+1 from me (although tests are unhappy) |
Member
Author
|
1 test job green; 8 red. That's good enough, I guess 🙈 🎉 (I checked. All failures known suspects) |
This was referenced Sep 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test only triggers the error case in about 70% of runs but I couldn't properly construct the race condition leading up to this. At the very least, this will not be falsely raising an exception
black distributed/flake8 distributed/isort distributed