Repository navigation
Conversation
Member
Author
|
Problem: The scheduler only knows about the executing worker state after a heartbeat got in. If the task consistently fails before this (e.g. immediately or during deserialization) the scheduler does not have the possibility to increase the counter, ever. I think this is a major problem and I don't have an easy way out. Closing this again but feel free to discuss if somebody has an idea (I think if we want this behavior we'd need to send a proper task state update to the scheduler once we transition it to executing; I'm not sure if this is worth it) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6386 (comment) for some more details
TODO