Repository navigation
Conversation
Current coverage is
|
Contributor
Author
There was a problem hiding this comment.
This configuration acts as a regression test for this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch addresses an issue where
spark-redshiftwould run into "Mandatory url is not present in manifest file" errors when saving data back to Redshift if a pre-2.0.0 version ofspark-avrowas used at runtime. This problem should not arise for most users ofspark-redshift, since the proper version ofspark-avroshould automatically be pulled in via Maven or Ivy; the goal of this patch is to provide compatibility for users who cannot upgradespark-avrofor other compatibility-related reasons.Cause of the write path bug: In order to fix a crash that could occur when writing tables containing empty partitions, #99 modified the write path to use manifest files that instruct Redshift to load only the non-empty partitions' Avro files. The code that handled processing of filenames when generating the manifest made assumptions about filenames that hold for spark-avro 2.0.0+ but not for spark-avro 1.0.0.
Solution: use a different method to build the correct list of part file names when constructing the manifest.
Fixes #111.