Skip to content

Fix workbench identity contract and trusted fork PR checks - #19

Merged
cinderzhan merged 1 commit into
dataelement:mainfrom
cinderzhan:codex/workbench-catalog-contract
Sep 28, 2026
Merged

cinderzhan merged 1 commit into
dataelement:mainfrom
cinderzhan:codex/workbench-catalog-contract

Conversation

@cinderzhan

Copy link
Copy Markdown
Collaborator

Summary

  • Align the submission contract with the current Desktop host: repository owner/repo is the canonical workbench identity. New YAML omits workbenchId; published catalog still derives the compatibility field for older consumers and preserves legacyWorkbenchIds migration.
  • Correct the catalog example, schema, validation, submission guide, and package-contract explanation.
  • Replace the workflow_run/commit-to-PR lookup with a pull_request_target probe that checks out trusted main, validates the exact PR number and head SHA, and only reads candidate YAML from the verified fork repository. Missing or stale PRs fail; the job itself is the PR check.

Verification

  • npm run check (57 tests passed)
  • git diff --check

Rollout note

The old trusted gate on main cannot validate this workflow change before merge. After merge, exercise a fresh ordinary fork PR and inspect the Trusted catalog probe log before treating its status as evidence. Merge this contract before publishing the revised website guides.

@cinderzhan
cinderzhan marked this pull request as ready for review September 28, 2026 10:14
@cinderzhan
cinderzhan merged commit 30cadbe into dataelement:main Sep 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant