Repository navigation
fix(market): clean stale temp directories and optimize pnpm config for Windows - #126
Merged
Merged
Conversation
yaojin3616
added a commit
that referenced
this pull request
Aug 21, 2026
yaojin3616
added a commit
that referenced
this pull request
Aug 21, 2026
Kunstderfug
added a commit
to Kunstderfug/dsh-desktop
that referenced
this pull request
Sep 16, 2026
…d escapable
Keep the pnpm side-effects cache DISABLED at both spawn sites: bundled pnpm 10.34.5 keys side-effect entries on ENGINE_NAME (${platform};${arch};node<MAJOR>), which is ABI-blind while pnpm runs under ELECTRON_RUN_AS_NODE against native modules (node-pty conpty failure family, dataelement#183). The disable is a deliberate opt-out introduced in dataelement#126 and preserved through dataelement#204/dataelement#220/dataelement#352 (profile .npmrc seed and generations staging pin), not inheritance.
Both buildHarnessSpawnOptions and buildProfilePluginCommandEnvironment now compute npm_config_side_effects_cache and PNPM_CONFIG_SIDE_EFFECTS_CACHE from one exported helper, pnpmSideEffectsCacheAllowed(): default 'false', overwriting any stray parent-shell npm_config value. DSH_PNPM_SIDE_EFFECTS_CACHE=1 (exact token) opts a diagnostic run back in; the two market-installer disable sites are cross-referenced but untouched so generation installs never see the hatch. Windows note documented: env names are case-preserved, so the hatch must be exported with exact casing.
Table-driven tests pin default-off, stray-parent override, near-miss token rejection, and exact '1' enablement for both builders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*_tmp_*directories inprofiles/web/node_modulesbefore install/uninstall and during recovery to prevent Windows rename/lock collisions.pnpm-lock.yamlon installer failures so subsequent retries can succeed.profiles/web/.npmrcwithpackage-import-method=clone-or-copyandchild-concurrency=1.PNPM_CONFIG_CHILD_CONCURRENCY=1andPNPM_CONFIG_PACKAGE_IMPORT_METHOD=clone-or-copyin both the Harness runtime spawn options and market installer child process environment.