Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #695.
The Windows wrappers replace
execandexecFilewithout their custom promisify hooks. Promise consumers consequently receive a stdout string instead of{ stdout, stderr }.execalso re-entersexecFilewith an options-object overload that the wrapper mishandled.Delegate to Node's native hooks after applying
windowsHide, rather than copying the hooks unchanged and bypassing the no-console policy. This preservesPromise.child, buffered output, failure diagnostics, and an explicitwindowsHide: false.Verified on macOS:
vitest run: 181 files, 1,639 tests passed.git diff --checkpassed.Native Windows application verification remains outstanding. Tests used an independent copy of the existing locked dependencies; a fresh
npm ciin the isolated checkout did not complete.