Repository navigation
fix(installer): handle wildcard exports redirecting package.json in resolveNonRootPackage (#745) - #757
Open
yaojin3616 wants to merge 1 commit into
Open
fix(installer): handle wildcard exports redirecting package.json in resolveNonRootPackage (#745)#757yaojin3616 wants to merge 1 commit into
yaojin3616 wants to merge 1 commit into
Conversation
…esolveNonRootPackage (#745)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
解决的问题
修复 #745:当插件依赖的包(如
@modelcontextprotocol/sdk)在其package.json中声明了子路径通配符导出(如"./*": "./dist/cjs/*")时,requireFromPackage.resolve("${dependency}/package.json")会命中通配符被重定向到子目录下的编译产物dist/cjs/package.json(通常仅含{"type": "commonjs"},无name字段)。现有逻辑因manifest.name !== dependency提前return undefined,导致正常的子路径包无法通过 peer 校验,插件安装必失败。变更说明
selectedManifest解析出的 manifest 缺少匹配的name时,向父级目录回溯寻找真正的包根package.json;resolve.paths的拼接路径,而不是短路退出。package.json路径。test/generation-installer.test.ts中新增对含"./*": "./dist/cjs/*"通配导出的 SDK 包的 peer 校验测试。验证
npm test -- test/generation-installer.test.ts全部 25 个测试用例通过。npm run typecheck干净通过。git diff --check无异常。