Repository navigation
fix(installer): resolve extensionless types declarations in resolveNonRootPackage (#722) - #758
Open
yaojin3616 wants to merge 1 commit into
Open
yaojin3616 wants to merge 1 commit into
yaojin3616 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
解决的问题
修复 #722：在
packages/dsh-desktop-market-installer/generations/installer.mjs中的resolveNonRootPackage处理纯声明包（declarationOnly）时，仅按manifest.types字面路径做existsSync检测。对于老式或省略扩展名的声明包（例如@types/retry@0.12.0中的"types": "index"），由于磁盘文件名为index.d.ts，导致检测必然返回undefined，进而引发 generation peer 校验失败，阻止插件安装/更新。变更说明
declarationOnly分支增加[declaration,${declaration}.d.ts,${declaration}.d.mts,${declaration}.d.cts]候选扩展名列表探测。test/generation-installer.test.ts的accepts type packages and subpath exports测试中加入不带扩展名的声明包（{ types: 'index' }）验证。验证
npm test -- test/generation-installer.test.ts全部 24 个测试用例通过。npm run typecheck干净通过。git diff --check无异常。