Repository navigation
fix(installer): validate missing Harness peers against current host (#744) - #760
Open
yaojin3616 wants to merge 1 commit into
Open
yaojin3616 wants to merge 1 commit into
yaojin3616 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #744. When a generation cannot resolve a missing @deepseek-ai/* dependency, validate it using the explicitly supplied current Harness installation anchor. Keep ordinary third-party packages plugin-owned; do not override existing private packages or exports errors.
Loading Contract
This changes installation-time generation peer validation, not runtime import order. It reads manifests from the generation and resolves only missing Harness packages from dshEntryPath. No generic installation-directory fallback, cwd changes, NODE_PATH, shared-tree mutation or Safe Mode change. Existing closure/private-singleton failures remain actionable.
Validation
Not Verified
Windows junctions/native process behavior, signed packaged application, authenticated browser bootstrap/UI activation and actual market update through the installed app. This does not resolve #723: allowing arbitrary host third-party peers would violate the repository's explicit host fallback boundary.