Repository navigation
Conversation
test_on_holder_table can fail even when find_min_global finds a global minimum. In a failed run it returned -19.2084981, which is 4.5e-6 above the minimum, while the test allowed 1e-7. The C++ tests of the Holder table functions allow 1e-4. The test now allows 1e-4 as well. Other than near the global minima, the function stays above -18.03 in the search box, so this still checks that a global minimum was found.
Owner
|
Thanks for the PR. |
reunanen
deleted the
use-the-cpp-tolerance-in-the-holder-table-python-test
branch
October 1, 2026 14:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_on_holder_tablecan fail even whenfind_min_globalfinds a global minimum. In a failed run it returned -19.2084981, which is 4.5e-6 above the minimum, while the test allowed 1e-7. The C++ tests of the Holder table functions allow 1e-4. The Python test now allows 1e-4 as well. Other than near the global minima, the function stays above -18.03 in the search box, so this still checks that a global minimum was found.