Remove removeLeadingDot option, making it the default#18
Merged
jakob101 merged 1 commit intoJul 18, 2017
Merged
Conversation
The leading dot is redundant, and should never be there. Some IDE's rightfully complain about this.
Contributor
|
This will make the extension harder to use for javascript (and probably other js-like languages such as TypeScript) as it will provide incorrect module paths for sibling files. |
Contributor
Author
|
What do you mean with "incorrect module paths for sibling files"? Why isn't |
Contributor
|
Oh wait, sorry I misread. You're correct with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The leading dot is redundant, and should never be there. Some IDE's
rightfully complain about this.