perf(cache): make the file watcher respect scan filters; smarter defaults#80
Merged
Conversation
…ults Four hardening fixes to the file-cache settings: - onDidCreate pushed every created file into the cache unfiltered, so a bulk creation like npm install flooded _fileNames with node_modules paths, bypassing ignore, includeGlob, and maxFilesCached. Created files now pass through the same filters as the findFiles scan (new pure glob-match module, unit-tested), respect the cap, and are skipped when outside the active workspace folder. Both watcher handlers also no longer throw if they fire before the first scan finishes. - Changing relativePath.includeGlob now triggers a re-scan; previously it silently did nothing until a workspace switch or reload. - relativePath.ignore default gains modern build-output dirs: dist, build, coverage, .turbo, .cache, .venv, __pycache__. - relativePath.searchCountLimit default raised 1000 -> 10000; modern quick pick handles that comfortably, so most projects get the one-step filter picker. Stale "performance issues" wording dropped. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
dawsbot
force-pushed
the
perf/harden-file-cache
branch
from
f5dfd0d to
f696985
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opened copy of #79, which was auto-closed when its stacked base branch was deleted during the #78 merge. Full write-up in #79; summary:
onDidCreatenow applies the sameignore/includeGlob/maxFilesCachedfilters as the findFiles scan (new unit-testedsrc/glob-match.ts), so bulk creations likenpm installno longer flood the cache. Watcher handlers no longer throw before the first scan finishes.relativePath.includeGlobtriggers a re-scan immediately.relativePath.ignoredefaults gain dist, build, coverage, .turbo, .cache, .venv, pycache.relativePath.searchCountLimitdefault raised 1000 to 10000.Testing:
npm test23/23, cleantsccompile.🤖 Generated with Claude Code