Ensure distinct --batch and --checkpoint files#1931
Merged
Conversation
to avoid --checkpoint logging SQL back to the source --batch. The --checkpoint argument is converted to a string, and the opened checkpoint is cached to avoid repeatedly seeking to the end of a large file. The change to a string is visible in Click's generated helpdoc. Incidentally improve the helpdoc for --resume, which looks like it may have been mangled by an agent during refactoring.
rolandwalker
force-pushed
the
RW/ensure-batch-checkpoint-distinct-files
branch
from
b55d091 to
dc8c098
Compare
scottnemes
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure distinct
--batchand--checkpointfiles, to avoid--checkpointlogging SQL back to the source--batch.The
--checkpointargument is converted to a string, and the opened checkpoint is cached to avoid repeatedly seeking to the end of a large file.The change to a string is visible in Click's generated helpdoc.
Incidentally improve the helpdoc for
--resume, which looks like it may have been mangled by an agent during refactoring.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).