fix: widen pydantic-core upper bound to <3.0.0 - #723
Closed
gavin913-lss wants to merge 1 commit into
Closed
Conversation
pydantic 2.13.3 requires pydantic-core==2.46.3, but the current constraint pins pydantic-core<2.44.0, making deepgram-sdk uninstallable alongside pydantic>=2.13.0. Widen the upper bound to <3.0.0 since pydantic-core follows calver and the API is stable within major versions. Fixes deepgram#701
GregHolmes
added a commit
that referenced
this pull request
Jun 3, 2026
) SDK regeneration for 2026-06-02. ## Generator bump `fernapi/fern-python-sdk` **5.8.3 → 5.14.8** (set in `deepgram-docs/fern/generators.yml`). SDK version `7.1.2 → 7.3.1`. ## Headline fix — closes #701, supersedes #723 The new generator widens the `pydantic-core` bound from `>=2.18.2,<2.44.0` to `>=2.18.2,<3.0.0` in both `pyproject.toml` and `requirements.txt`, and regenerates `poetry.lock` (now resolves `pydantic-core 2.46.4`). This fixes the resolver conflict with `pydantic>=2.13` at the generator level, so the manual one-line patch in #723 is no longer needed. ## Manual patches reconciled All 20 temporarily-frozen files were diffed (`.bak` vs regenerated). The generator caught up on **none** of them, so all 20 patches were re-applied and re-frozen in `.fernignore`: - `core/query_encoder.py` — bool→lowercase coercion for websocket query strings - 4 socket clients — broad `except Exception`, optional control-message params, agent `_sanitize_numeric_types`, listen/v2 `send_configure` raw shim - 7 agent-settings type/request files — back-compat for the 2026-05-05 schema restructure (callable `AgentV1SettingsAgent(...)`, legacy `messages=`/nested-context remap, `.messages` read access, `str` audio container). Note: 5.14.8 now natively types `AgentV1SettingsAgent = Union[AgentV1SettingsAgentContext, str]`; the callable-class shim is retained for constructor back-compat. - 7 package `__init__.py` files — legacy alias re-exports (no new generator entries to merge; all showed `new+:0`) - `tests/wire/test_manage_v1_projects_keys.py` — legacy create-key alias wire coverage ## Verification - `poetry run mypy src/` — clean (801 files) - `poetry run pytest -rP .` — 222 passed, 4 skipped (incl. all custom back-compat regression tests) - Pre-existing ruff findings in `tests/manual`/`tests/custom` are unchanged and not CI-gated. --------- Co-authored-by: fern-api <115122769+fern-api[bot]@users.noreply.github.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
deepgram-sdkpinspydantic-core>=2.18.2,<2.44.0, butpydantic>=2.13.0requirespydantic-core==2.46.3. This makes it impossible to installdeepgram-sdkalongside modernpydantic:Fixes #701
Fix
Widen the
pydantic-coreupper bound from<2.44.0to<3.0.0.pydantic-corefollows calver and the validation/serialization API is stable within major versions. The lower bound>=2.18.2is preserved to maintain backward compatibility.Testing
Verified that
pydantic==2.13.3+pydantic-core==2.46.3satisfies the new constraint>=2.18.2,<3.0.0.