Skip to content

apps:run test with lengthy output -- don't log actual output on failure #360

Open

Description

@vdice

When/if this apps:run test fails, the Expect statement proceeds to log the entire command's output, corrupting the user's terminal and crowding out logs with byte code.

We should re-jigger the test, perhaps checking first if the byte array does not match expected (outside of Expect) and then, if not, logging some standard error/failure message accordingly.

Activity

  1. added this to the v2.16 milestone on May 26, 2017
  2. vdice commented on May 31, 2017

    @vdice
    MemberAuthor

    Alas, since the output is stored in sess.Out.ContentsI(), Ginkgo will log this anytime the test fails (no matter how test is failed). Wondering if there's another way to eliminate logging of output? Or, another way to test this case? ping @mboersma

  3. removed their assignment
    on Jul 3, 2017
  4. removed this from the v2.16 milestone on Jul 3, 2017
  5. Cryptophobia commented on Mar 21, 2018

    @Cryptophobia

    This issue was moved to teamhephy/workflow-e2e#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions