Skip to content

fix(server): make stop requests target and confirm active turns - #9

Open
demget wants to merge 1 commit into
mainfrom
coda/fix-stop-button-reliability
Open

demget wants to merge 1 commit into
mainfrom
coda/fix-stop-button-reliability

Conversation

@demget

@demget demget commented Aug 7, 2026

Copy link
Copy Markdown
Owner

What Changed

  • Target provider interrupts at the active turn ID.
  • Wait for provider confirmation before marking a turn interrupted.
  • Preserve active-turn tracking when turns are queued or complete out of order.
  • Record a visible activity when an interrupt fails without falsely stopping the turn.
  • Align Codex and Grok adapter behavior and add focused coverage across server and client runtime layers.

Why

Stop requests could interrupt the wrong turn or mark a turn as stopped before the provider confirmed it. This caused stale running states and unreliable stop behavior, especially when turns were queued or provider events arrived out of order. The change keeps orchestration state aligned with provider-confirmed results and preserves the active turn when an interrupt fails.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

- Preserve active turn IDs across queued Codex turns
- Confirm interruptions only after provider success and surface failures
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L labels Aug 7, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant