Upgrade postcss-values-parser to version 5 - #107
Merged
Conversation
8 tasks
joscha
reviewed
Mar 30, 2021
joscha
reviewed
Mar 30, 2021
joscha
reviewed
Mar 30, 2021
| "module": "commonjs", | ||
| "target": "es2018" | ||
| "target": "es2018", | ||
| "paths": { |
Contributor
Author
There was a problem hiding this comment.
This is necessary to make the override of types that exist in postcss-values-parser work. Once upstream is fixed, this can go away.
Collaborator
Ah sorry, missed this when reading first. Link the PR here when you opened it! |
Contributor
Author
|
There's 3 relevant PRs to this:
|
Collaborator
sorry for beings so slow - all of these have been merged, can this PR now simplified @realityking ? |
Contributor
Author
|
While they’ve all been merged, shellscape/postcss-values-parser hasn’t yet made a release with the changes. |
Collaborator
|
I've nudged on these pull requests :) |
Collaborator
|
released in |
Contributor
Author
|
❤️ I’ll send a clean-up PR once the upstream is updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101
Version 5 is now using PostCSS 8 so there's no more necessary duplication holding back the upgrade.
This got more complex than expected, mostly because I was trying to use the upstream types. Unfortunately there are several errors in those types. I ended up copying (& fixing) the relevant parts into the definition file. When I get around to it, I'll submit a PR to the upstream to fix the types and the extra definition file can be eliminated.
As an alternative, I could simplify the definition file similar to the previous one and remove the type narrowing code. That would preclude using the upstream types in the future.