Repository navigation
build: take the pending NuGet patch bumps in one commit - #337
Merged
Merged
Conversation
Dependabot had opened fifteen overlapping PRs for the same set of patch updates - one per group per nuget update block, since the three blocks (root, notifications host, flex-fields demo) all edit the shared Directory.Packages.props and the two hosts' inline pins - and the ones that touched only the props failed with NU1605 downgrades in the hosts. This commit applies the full set once, in every place: - Microsoft.Extensions.* / System.Text.Json / Microsoft.EntityFrameworkCore.* 10.0.11 -> 10.0.12 (props and both host csproj files) - Microsoft.SourceLink.GitHub 10.0.400 -> 10.0.401 - Microsoft.NET.Test.Sdk 18.9.0 -> 18.10.1 - Polly 8.6.3 -> 8.8.0 - Markdig 1.3.2 -> 1.4.0 Also collapse the three nuget update blocks in dependabot.yml into one `directories:` block, so a future bump produces a single PR that covers the props and both hosts together instead of three partial ones. Groups and ignores are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the fifteen overlapping dependabot NuGet PRs (#253, #262, #295, #297, #298, #299, #302, #308, #310, #311, #312, #322, #325, #332, #249) with one commit that applies the full set of pending patch bumps everywhere they are pinned:
Why one commit: the three nuget update blocks in
dependabot.yml(root, notifications host, flex-fields demo) all edit the sharedDirectory.Packages.propsplus the hosts' inline pins, so every group in every block opened its own partial PR, and the ones that bumped only the props failed CI with NU1605 downgrades in the hosts. No single PR covered the whole set. Once this is onmain, dependabot closes the fifteen itself as no longer needed.Also collapses those three blocks into one
directories:block so a future bump produces a single PR covering the props and both hosts. Groups and ignores are unchanged.Verification
dotnet build Dignite.Abp.Modules.slnxon this branch: 0 errors, 0 warnings.