Skip to content

mangling underscore as an argument #7

Closed

Description

@Gruruya

Needs some new name-mangling, currently compiling disruptek/github with Nim devel errors with:

Error: undeclared identifier: '_'

Error was introduced with nim-lang/Nim@05c6db6
Manually replacing everywhere _ is used as an argument with another name fixes the error.

Activity

  1. disruptek commented on Mar 1, 2023

    @disruptek
    Owner

    Yeah, it's annoying. Not sure when I will have time to fix it, but do you have a suggestion for what to change the argument name to? Obviously, it needs to be clash-free with virtually any keyword argument that might be present in any API. 🙄

  2. pinned this issue on Mar 1, 2023
  3. Gruruya commented on Mar 1, 2023

    @Gruruya
    Author

    You could use was_an_underscore_ID, mangled or mg_underscore_ID, underscore_par/prm_ID. Pretty much any prefix or suffx with "underscore" would work. None of my suggestions showed any results on github code search.

  4. disruptek commented on Mar 1, 2023

    @disruptek
    Owner

    Let's just major it and rename the argument to content or somesuch.

  5. Gruruya commented on Mar 1, 2023

    @Gruruya
    Author

    ya sure

  6. disruptek commented on Mar 1, 2023

    @disruptek
    Owner

    Closed in 65f7748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions