New sort mode Perishable - #7
Open
LukasKanta wants to merge 3 commits into
Open
LukasKanta wants to merge 3 commits into
LukasKanta wants to merge 3 commits into
Conversation
- Add alphabetical sorting to unperishable items in ByPerishable sort mode
Kankro
added a commit
to Kankro/packrat
that referenced
this pull request
May 15, 2026
Adds a new sorting method that orders items from next-to-perish to last-to-perish. Unperishable items are listed at the end in alphabetical order. - Added new sort mode Perishable to the dropdown - Added new sort mode ByPerishable to the SortMode enum - Changed the signature of GetSortKey to take ItemSlot instead of ItemStack. This is needed to access the transition state - Moved logic for Alphabetical order into new method GetAlphabeticalKey - Added a new method GetRealFreshHoursLeft to determine hours remaining until a perish transition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new sorting method that orders items from next-to-perish to last-to-perish. Unperishable items are listed at the end in alphabetical order.
Changes
ByPerishableto theSortModeenumGetSortKeyto takeItemSlotinstead ofItemStackGetAlphabeticalKeyGetRealFreshHoursLeftto determine hours remaining until a perish transitionMotivation / Context
I wanted an easy way to quickly find items in my cellar that are about to spoil.
Testing
Breaking Changes
Additional Notes
I’m not fully sure about the naming in the dropdown and am open to better suggestions.