Skip to content

Translate _d_arraysetassign to a template - #14382

Merged
RazvanN7 merged 1 commit into
dlang:masterfrom
teodutu:template-_d_arraysetassign
Sep 15, 2022
Merged

RazvanN7 merged 1 commit into
dlang:masterfrom
teodutu:template-_d_arraysetassign

Conversation

@teodutu

@teodutu teodutu commented Aug 26, 2022

Copy link
Copy Markdown
Member
  • Implement template _d_arraysetassign
  • Lower array asignments to a single element to the above template
  • Remove old lowering from e2ir.d
  • Remove the old _d_arraysetassign hook and its file rt/arrayassign.d

This follows the implementation of the template _d_arrayassign_{l,r} hooks: #14310.

@teodutu
teodutu requested a review from ibuclaw as a code owner August 26, 2022 11:09
@dlang-bot

dlang-bot commented Aug 26, 2022 •

Copy link
Copy Markdown

Thanks for your pull request, @teodutu!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14382"

@teodutu
teodutu force-pushed the template-_d_arraysetassign branch 2 times, most recently from ab6a4c8 to 37a53df Compare August 27, 2022 10:43
Comment thread compiler/src/dmd/expressionsem.d Outdated
Comment thread compiler/src/dmd/utils.d Outdated
@teodutu
teodutu force-pushed the template-_d_arraysetassign branch from 37a53df to aa83d13 Compare September 11, 2022 15:30
@teodutu
teodutu requested review from ibuclaw and ntrel and removed request for ibuclaw and ntrel September 11, 2022 16:47

@RazvanN7 RazvanN7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind the nits.

Comment thread compiler/src/dmd/expression.d Outdated
Comment thread compiler/src/dmd/expressionsem.d Outdated
Comment thread compiler/src/dmd/expressionsem.d Outdated
Comment thread compiler/src/dmd/expressionsem.d Outdated
@RazvanN7 RazvanN7 added the Merge:72h no objection -> merge The PR will be merged if there are no objections raised. label Sep 13, 2022
- Implement template `_d_arraysetassign`
- Lower array asignments to a single element to the above template
- Remove old lowering from e2ir.d
- Remove the old `_d_arraysetassign` hook and its file rt/arrayassign.d
- Add test for assigning a struct with a `@disabled` postblit

Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
@teodutu
teodutu force-pushed the template-_d_arraysetassign branch from aa83d13 to 12eba10 Compare September 13, 2022 13:27
@RazvanN7
RazvanN7 merged commit d0a367e into dlang:master Sep 15, 2022
@teodutu
teodutu deleted the template-_d_arraysetassign branch September 17, 2022 12:21
nybzmr added a commit to nybzmr/dmd that referenced this pull request Mar 19, 2025
thewilsonator pushed a commit that referenced this pull request Mar 19, 2025
* Remove RTLSYM for Translation PR #15819: Removed NEWARRAYMITX, NEWARRAYMITX, TRACENEWARRAYMTX and TRACENEWARRAYMITX

* Remove RTLSYM for Translation PR #15299: Removed NEWARRAYT, NEWARRAYIT, TRACENEWARRAYT and TRACENEWARRAYIT

* Remove RTLSYM for Translation PR #14837: Removed NEWCLASS, TRACENEWCLASS

* Remove RTLSYM for Translation PR #14664: Removed NEWITEMT, NEWITEMIT, TRACENEWITEMT and TRACENEWITEMIT

* Remove RTLSYM for Translation PR #14550: Removed ARRAYCATNTX, ARRAYCATT, TRACEARRAYCATNTX and TRACEARRAYCATT

* Remove RTLSYM for Translation PR #14382: Removed ARRAYSETASSIGN

* Remove RTLSYM for Translation PR #14310: Removed ARRAYASSIGN

* Remove RTLSYM for Translation PR #13495: Removed ARRAYAPPENDT, ARRAYAPPENDCTX, TRACEARRAYAPPENDT and TRACEARRAYAPPENDCTX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge:72h no objection -> merge The PR will be merged if there are no objections raised.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants