Repository navigation
Issue 13120 - Body of foreach over string with transcoding ignores function attributes - #3956
Merged
Merged
Conversation
Contributor
Author
|
Requires phobos fix: dlang/phobos#2493 |
Member
There was a problem hiding this comment.
Please add comment explaining why pure is in a comment. If it is inferred to be pure, then the comment should say that.
…f it uses member field or function
…array in pure function allow impure function calls
…res function attributes
Member
|
Auto-merge toggled on |
WalterBright
added a commit
that referenced
this pull request
Nov 13, 2014
Issue 13120 - Body of `foreach` over string with transcoding ignores function attributes
|
Commit e40077c introduced a regression: https://issues.dlang.org/show_bug.cgi?id=13840 |
Member
|
This pull request introduced a regression: |
Member
|
Thanks for tracking this @CyberShadow , it made finding the root cause so much easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=13120
Based on the PR #3626.