Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Issue 23212 - Improve documentation of rt/aApply - #3865

Merged
dlang-bot merged 1 commit into
dlang:masterfrom
dkorpel:doc-rt-aapply
Jul 4, 2022
Merged

Issue 23212 - Improve documentation of rt/aApply#3865
dlang-bot merged 1 commit into
dlang:masterfrom
dkorpel:doc-rt-aapply

Conversation

@dkorpel

@dkorpel dkorpel commented Jun 30, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@dlang-bot

Copy link
Copy Markdown

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23212 enhancement missing documentation for druntime hooks

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3865"

@thewilsonator thewilsonator left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good

Comment thread src/rt/aApply.d Outdated
@RazvanN7

RazvanN7 commented Jul 4, 2022

Copy link
Copy Markdown
Contributor

Documentation tester:

src/rt/aApply.d(24): Warning: Ddoc: function declaration has no parameter 'c'
src/rt/aApply.d(507): Warning: Ddoc: function declaration has no parameter 'i'
src/rt/aApply.d(507): Warning: Ddoc: function declaration has no parameter 'c'

It seems that you cannot put the delegate parameter of a delegate declaration in the documentation. Maybe you can refer to it without actually putting it in the Params section.

@dkorpel
dkorpel deleted the doc-rt-aapply branch July 4, 2022 12:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants