Repository navigation
Conversation
Keep the registry host clients instead of replacing them with the default tracing client, which discards configured CAs and client certificates. This fixes imagetools requests and multi-node manifest merging against registries that use a private CA or require mutual TLS. The registry clients already include tracing and the resolver's intended transport settings. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
3 tasks done
jsternberg
approved these changes
Nov 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve the configured registry clients in imagetools instead of replacing them with
tracing.DefaultClient, which discards custom CAs and client certificates. This fixes imagetools requests and multi-node manifest merging against registries that use a private CA or require mutual TLS.The registry clients already wrap their TLS transport with tracing and use the resolver's transport settings, including disabling HTTP/2 for push performance.