Skip to content

imagetools: preserve registry TLS settings - #4222

Open
crazy-max wants to merge 1 commit into
docker:masterfrom
crazy-max:fix-imagetools-registry-tls
Open

crazy-max wants to merge 1 commit into
docker:masterfrom
crazy-max:fix-imagetools-registry-tls

Conversation

@crazy-max

Copy link
Copy Markdown
Member

Preserve the configured registry clients in imagetools instead of replacing them with tracing.DefaultClient, which discards custom CAs and client certificates. This fixes imagetools requests and multi-node manifest merging against registries that use a private CA or require mutual TLS.

The registry clients already wrap their TLS transport with tracing and use the resolver's transport settings, including disabling HTTP/2 for push performance.

Keep the registry host clients instead of replacing them with the default
tracing client, which discards configured CAs and client certificates.

This fixes imagetools requests and multi-node manifest merging against
registries that use a private CA or require mutual TLS.

The registry clients already include tracing and the resolver's intended
transport settings.

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error when merging multi-platform manifest(s) to custom tls config registry after successfully pushing for individual platforms

2 participants