Repository navigation
Conversation
Signed-off-by: Sami Chergui <83331159+Yshuro@users.noreply.github.com>
Pass the parsed age limit directly to DiskUsage instead of introducing a single-use option helper. Verify that fresh local-source cache is present before filtering and excluded by both until and unused-for. Combine each age filter with a type filter so the integration test catches dropped age limits and checks filter composition. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
fix-du-until
branch
from
November 19, 2026 19:41
c7230bc to
4445e9e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the parsed
untilduration to BuildKit's DiskUsage API sodocker buildx du --filter until=24hexcludes recently used cache records. Previously, the duration was parsed but discarded before the API call, silently ignoring the age filter. This also fixes the deprecatedunused-foralias.This carries forward the original commit from #4221, simplifies the option handling, and strengthens the integration test to verify that both age filters exclude fresh cache when combined with a type filter. The focused parser tests and integration test with the remote worker pass.