Repository navigation
Conversation
In compose service volume specifications, tmpfs mounts can declare a mode option (e.g. mode: 01777). Previously, internal/volumespec/types.go omitted the Mode field on TmpFsOpts, and handleTmpfsToMount in cli/compose/convert/volume.go did not map the Mode attribute into mount.TmpfsOptions. Add Mode to volumespec.TmpFsOpts, map it to mount.TmpfsOptions, and add unit tests to verify loader unmarshaling and volume conversion. Fixes docker#7454 Signed-off-by: Mohamed Makhlouf <md.3omer@gmail.com>
Author
|
Closing in favor of #7455, which was opened earlier and addresses the same issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In compose service volume specifications, tmpfs mounts can declare a
modeoption (e.g.mode: 01777).Previously:
internal/volumespec/types.goomitted theModefield onTmpFsOpts.handleTmpfsToMountincli/compose/convert/volume.godid not map theModeattribute intomount.TmpfsOptions.Consequently, when deploying via
docker stack deploy, the permissions mode was ignored and the tmpfs mount defaulted to daemon standard permissions.This patch:
Mode uint32tovolumespec.TmpFsOpts.Mode: os.FileMode(volume.Tmpfs.Mode)intomount.TmpfsOptionsincli/compose/convert/volume.go.cli/compose/loader/loader_test.goandcli/compose/convert/volume_test.goverifying thatmodeis properly unmarshaled from compose YAML and mapped to Swarm mount options.Release notes (optional)