Repository navigation
fix: bind take_load_error for the threaded renderer - #432
Merged
Merged
Conversation
A failed load through _threaded_pdf_renderer raised AttributeError instead of PdfLoadError, because _load_error() calls take_load_error and only the two parsers bound it. Signed-off-by: Christoph Auer <cau@zurich.ibm.com>
Contributor
|
✅ DCO Check Passed Thanks @cau-git, all your commits are properly signed off. 🎉 |
Contributor
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
cau-git
marked this pull request as ready for review
October 29, 2026 14:57
PeterStaar-IBM
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_load_error()(added in #414) callsnative_parser.take_load_error(key)whenever a load fails, but only_pdf_parserand_threaded_pdf_parserbound it. A failed load throughDoclingThreadedPdfParserwith arender_config(e.g. a missing file) therefore raisedAttributeError: '_threaded_pdf_renderer' object has no attribute 'take_load_error'instead ofPdfLoadError. Seen on CI for #411 when the regression PDF was not yet in the pinned dataset.take_load_erroron_threaded_pdf_renderer, same as the threaded parser.tests/test_unit_*.py: 307 passed, 2 skipped.