Repository navigation
uncaught reference in 4.11 #1057
Description
Bug Report
When using the freshly released version 4.11 I observe that the library doesn't load and the problem seems to be on the docsify side.
Steps to reproduce
Use index.html like this one
What is current behaviour
docsify doesn't load
What is the expected behaviour
docsify loads :)
Other relevant information
-
Bug does still occur when all/other plugins are disabled?
-
Your OS: Ubuntu
-
Browser version: chrome Version 80.0.3987.132 (Official Build) (64-bit)
-
Docsify version: 4.11
-
Docsify plugins: docsify-katex (but the problem appears also without it).
Activity
anikethsaha commentedon Mar 9, 2020
ohh shoot !
Please use
4.10.2I will fix it now . Something wrong with rollup config
akhmerov commentedon Mar 9, 2020
Yeah, I pinned 4.10.2, sure, no problem.
vardaro commentedon Mar 9, 2020
Wow you guys are fast!
anikethsaha commentedon Mar 9, 2020
if anyone can help with this rollup issue .
Thanks
slikts commentedon Mar 9, 2020
There shouldn't be untested releases; the default setup doesn't pin the version, so every site that uses it is now broken. It's also why the default template should include a fallback link.
Pinned location:
//unpkg.com/docsify@4.10.2/lib/docsify.min.jsanikethsaha commentedon Mar 9, 2020
released
v4.11.1Please confirm if there are any issues or not
xuqingkuang commentedon Mar 9, 2020
Try to execute npm ls css.escape, to make sure the css.escape is installed?
I tested to build the docsify, the css.escape was built correctly.
slikts commentedon Mar 9, 2020
v4.11.1appears to work, thanks for the fix, but please add automated testing to the process.anikethsaha commentedon Mar 9, 2020
We do have some e2e tests but they are not so strong and not many!
I am not so into testing so I couldn't able to write strong tests.
So I request community to help with strong tests!
anikethsaha commentedon Mar 9, 2020
Closing as its been fix.
Please open new issue if any other issue is there
jeffin143 commentedon Mar 9, 2020
I will be there from next weekend to help :)
Great work anyways
anikethsaha commentedon Mar 9, 2020
🎉
Thanks
trusktr commentedon Jun 7, 2020
Just FYI the new unit tests in #1189 should catch any instance of the script not loading.
anikethsaha commentedon Jun 7, 2020
will it catch while running in development mode ? cause this issue occurred after running the build and ignoring the warning of rollup.
trusktr commentedon Jun 7, 2020
Oh wait, actually the
testscript currently tests whatever build you last made. I will updatetestto test specifically the prod build.EDIT: Oh wait, pull request #1189 does already test the production script. I added comments to the PR to explain it.
anikethsaha commentedon Jun 7, 2020
Post build tests ? worth it though, may be in a separate PR ?