Expose SQL query capture via govisual.WrapDriver#52
Merged
Conversation
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The driver-level SQL hook has existed since the profiling work but was unreachable: it needed a *Profiler handle that only Wrap ever held. Recording now goes through the request context (profiling.RecordSQL pulls the profile from ctx and is a no-op without one), which makes the hook handle-free and safe to expose.
govisual.WrapDriver(d) wraps any database/sql driver; register it once, open the DB through it, and queries executed with the request's context show up on that request's profile — query text, duration, rows, error — feeding the existing per-request SQL view and the database-bottleneck analysis.
Tests cover recording through a real database/sql round trip against a fake driver, and the no-profile pass-through.