fix: list a rescue when: on failed_task as unknown - #465
Merged
josegonzalez merged 1 commit intoAug 12, 2026
Merged
Conversation
`failed_task` is bound only once a block child has failed, so a rescue predicate branching on it is undecidable offline for the same reason a `registered` reference is, and `--list-tasks` now renders it `[unknown]` instead of reporting a valid recipe as broken. The reference check reads the parsed identifiers rather than the raw source, so an input named `registered_at`, a quoted `"registered"`, or a field access `x.failed_task` no longer forces a false `[unknown]`, and `failed_task` counts only where the executor actually binds it. With that false positive gone, a task `when:` that fails to evaluate now exits 1 like a play one, except under a group whose own predicate was skipped, unknown, or erroring, where a run would never evaluate it.
josegonzalez
deleted the
462-list-tasks-reports-a-rescue-when-on-failed-task-as-when-instead-of-unknown
branch
August 12, 2026 16:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
failed_taskis bound only once a block child has failed, so a rescue predicate branching on it is undecidable offline for the same reason aregisteredreference is, and--list-tasksnow renders it[unknown]instead of reporting a valid recipe as broken. The reference check reads the parsed identifiers rather than the raw source, so an input namedregistered_at, a quoted"registered", or a field accessx.failed_taskno longer forces a false[unknown], andfailed_taskcounts only where the executor actually binds it. With that false positive gone, a taskwhen:that fails to evaluate now exits 1 like a play one, except under a group whose own predicate was skipped, unknown, or erroring, where a run would never evaluate it.Fixes #462.