Skip to content

[no-release-notes] Run feature-specific GMS script test suites - #3491

Merged
zachmu merged 22 commits into
mainfrom
zachmu/split-script-queries
Oct 10, 2026
Merged

zachmu merged 22 commits into
mainfrom
zachmu/split-script-queries

Conversation

@zachmu

@zachmu zachmu commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Uses the consolidated script-test runners from GMS #3990, alongside Dolt #12009.

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor
Main PR
Total 42090 42090
Successful 20956 20955
Failures 21134 21135
Partial Successes1 5405 5405
Main PR
Successful 49.7885% 49.7862%
Failures 50.2115% 50.2138%

${\color{red}Regressions (1)}$

subselect

QUERY:          select count(*) from tenk1 t
where (exists(select 1 from tenk1 k where k.unique1 = t.unique2) or ten < 0);
RECEIVED ERROR: timeout during Receive

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct. ↩

@itoqa

itoqa Bot commented Oct 1, 2026

Copy link
Copy Markdown

Ito QA test results
Commit: 64338a2: 8 test cases ran, 8 passed ✅.

Summary

Coverage focuses on the application’s themed SQL behavior across supported queries, joins, subqueries, aggregations, compatibility boundaries, and harness lifecycle behavior. It also checks edge cases such as unsupported and multiline queries being skipped correctly while valid nearby queries continue to run, along with suite registration and dependency integration.

Safe to merge — the exercised application behaviors completed successfully, including supported query execution, intentional compatibility skips, suite isolation, and dependency integration. No PR-attributable regressions or unresolved failures were identified; the run is low risk.

Tests run by Ito

View full run

Result Severity Type Description
✅ — General The themed integration suites completed successfully. Known incompatible cases were skipped, while supported nearby cases ran and passed without a fixed-port startup conflict.
✅ — General The joins-and-subqueries command ran its own non-empty suite, and the separate aggregation command ran aggregation cases. Both commands finished successfully without a fixed-port startup error.
✅ — Compatibility The twelve themed compatibility suites completed successfully after the dependency upgrade. Supported scripts were evaluated, and known unsupported cases were intentionally excluded without causing compatibility failures.
✅ — Harness All twelve themed suites completed successfully. Known incompatible queries were skipped, supported cases ran, and each suite finished without a fixed-port startup conflict.
✅ — Harness The themed test run skipped known unsupported queries, including the multiline recursive query and intentional substring matches, while supported cases continued and the full package passed.
✅ — Rev The test listing found all twelve expected themed suites exactly once, and the targeted run completed successfully.
✅ — Rev The updated Go dependency resolves to the requested version, its checksums verify, and the aggregation test passes.
✅ — Suites The Go test run completed all twelve themed script suites successfully. Expected unsupported cases were skipped, and no suite failed.

Tip

Reply with @itoqa to send us feedback on this test run.

@coffeegoddd

coffeegoddd commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

@zachmu DOLT

read_tests from_latency to_latency percent_change
covering_index_scan_postgres 2.48 2.48 0.0
groupby_scan_postgres 82.96 82.96 0.0
index_join_postgres 2.3 2.39 3.91
index_join_scan_postgres 1.7 1.67 -1.76
index_scan_postgres 467.3 467.3 0.0
oltp_point_select 0.39 0.39 0.0
oltp_read_only 6.67 6.67 0.0
select_random_points 0.74 0.74 0.0
select_random_ranges 1.1 1.08 -1.82
table_scan_postgres 467.3 475.79 1.82
types_table_scan_postgres 1170.65 1191.92 1.82
write_tests from_latency to_latency percent_change
oltp_delete_insert_postgres 4.57 4.57 0.0
oltp_insert 2.18 2.26 3.67
oltp_read_write 12.75 12.75 0.0
oltp_update_index 2.52 2.52 0.0
oltp_update_non_index 2.22 2.22 0.0
oltp_write_only 5.99 5.88 -1.84
types_delete_insert_postgres 5.09 5.0 -1.77

@zachmu zachmu changed the title [no-release-notes] Run themed GMS script test suites [no-release-notes] Run feature-specific GMS script test suites Oct 2, 2026
@itoqa

itoqa Bot commented Oct 2, 2026

Copy link
Copy Markdown

Ito QA test results
Ito Diff Report — 64338a2 → b3f88bd: 6 test cases ran, 6 passing ✅.

Diff Summary

Coverage focuses on end-to-end database behavior for themed script suites, including supported query results, expected error handling, configured incompatibilities, suite registration, isolation, cleanup, and avoiding resource conflicts. The run also checks that upgraded scripts and aggregation flows behave correctly across both normal and edge-case scenarios.

Safe to merge — the exercised behaviors remain healthy with no PR-attributable regressions, new failures, or previously flagged failures still failing. Several previously passing checks were not rerun, so they remain a flag for later rather than a merge blocker.

Tests run by Ito

View full run

Result State Severity Type Description
✅ Passing — General All exposed themed test entry points were discovered and ran through the Doltgres harness. The package passed in 11.601 seconds, with supported cases evaluated and configured cases explicitly skipped.
✅ Passing — Compatibility The upgraded script suites ran through the PostgreSQL-compatible Doltgres harness and completed successfully. Supported cases passed their row or error checks, while known incompatible cases were skipped.
✅ Passing — Harness The full themed suite completed successfully. Known incompatible cases were skipped, supported cases ran, and later suites started without a fixed-port conflict.
✅ Passing — Harness Known incompatible script cases were skipped, while supported cases with no matching skip entry ran and passed.
✅ Passing — Suites All selected themed script suites ran through the local Doltgres test harness and finished successfully. Expected skips were the only exclusions.
✅ Passing — Suites The named aggregation suite ran through its Doltgres test harness and finished successfully. Supported checks passed and configured incompatible cases were skipped as expected.
⏸️ Skipped — General The joins-and-subqueries command ran its own non-empty suite, and the separate aggregation command ran aggregation cases. Both commands finished successfully without a fixed-port startup error.
⏸️ Skipped — Rev The test listing found all twelve expected themed suites exactly once, and the targeted run completed successfully.
⏸️ Skipped — Rev The updated Go dependency resolves to the requested version, its checksums verify, and the aggregation test passes.

Tip

Reply with @itoqa to send us feedback on this test run.

@itoqa

itoqa Bot commented Oct 8, 2026

Copy link
Copy Markdown

Ito QA test results
Ito Diff Report — b3f88bd → c7426fa: 14 test cases ran, 1 new failure ❌, 11 passing ✅, 2 additional findings ⚠️.

Diff Summary

The run covers PostgreSQL-compatible database behavior across normal role and permission flows, transaction and setting lifecycles, trigger handling, and adversarial type, catalog, and invalid-command edge cases. Core flows are broadly healthy, but a catalog-row compatibility path fails for valid whole-row function calls.

Merge with caution — the PR introduces a medium-severity compatibility failure affecting valid catalog-row queries, so the change is not risk-free. Separate medium-severity findings are not attributable to this PR and are flag-for-later observations rather than merge blockers.

Tests run by Ito

View full run

Result State Severity Type Description
❌ ❌ New Failure Medium severity Catalog Calling row_to_json with an aliased pg_catalog.pg_type row fails with a composite-type error. The same error occurs for the qualified whole-row form and the bare row form.
✅ Passing — General The required browser check used HTTP against a PostgreSQL database service, so it could not run the SQL scenario. The focused regression test passed, and the application code restores settings created after a savepoint when that savepoint is rolled back.
✅ Passing — General The ordinary member could not create a database or table, read the protected table, or run the protected routine just because it belonged to a superuser group. A group grant allowed only the specific access it was given.
✅ Passing — Identity The connection completed startup, showed the ordinary role as both session and current user, and successfully ran SELECT 1.
✅ Passing — Inheritance A direct grant, a broader schema grant, and group membership each let the correct role read the protected row.
✅ Passing — Journal The same database session kept the session value after COMMIT, discarded the local value, and restored the earlier value after ROLLBACK.
✅ Passing — Privilege After switching to the member role, the protected query returned the member-only row. Resetting the role restored the login role.
✅ Passing — Regprocedure A local procedure was created, and its OID, integer, and regproc values all converted to regprocedure with the same procedure identity.
✅ Passing — Role The client changed to the authorized target role and RESET ROLE restored the original client role.
✅ Passing — Role The database rejected an unauthorized role change, reported a missing role, and rejected a multiple-value role command with the expected errors.
✅ Passing — Setting The session kept its setting after SET, showed the local value inside the transaction, restored the session value after ROLLBACK, and reset application_name to its default.
✅ Passing — Trigger Verified acceptable by independent adversarial review: the reported expectation does not match what the code actually promises. Review notes: The rejection is real, but the finding turns the PR's internal operation mapping into a new feature obligation that the change does not establish. The PR fixes TG_OP propagation for supported row triggers, its added test covers only INSERT, UPDATE, and DELETE, and the unchanged CREATE TRIGGER conversion still marks both statement-level and TRUNCATE triggers as unsupported. Those guards describe a …
⏸️ Skipped — General All exposed themed test entry points were discovered and ran through the Doltgres harness. The package passed in 11.601 seconds, with supported cases evaluated and configured cases explicitly skipped.
⏸️ Skipped — Compatibility The upgraded script suites ran through the PostgreSQL-compatible Doltgres harness and completed successfully. Supported cases passed their row or error checks, while known incompatible cases were skipped.
⏸️ Skipped — Harness The full themed suite completed successfully. Known incompatible cases were skipped, supported cases ran, and later suites started without a fixed-port conflict.
⏸️ Skipped — Harness Known incompatible script cases were skipped, while supported cases with no matching skip entry ran and passed.
⏸️ Skipped — Suites All selected themed script suites ran through the local Doltgres test harness and finished successfully. Expected skips were the only exclusions.
⏸️ Skipped — Suites The named aggregation suite ran through its Doltgres test harness and finished successfully. Supported checks passed and configured incompatible cases were skipped as expected.
⚠️ Additional Finding Medium severity General The rejected insert returned the expected CHECK constraint error, but its BEFORE INSERT trigger wrote an audit row with amount -1. The target table had no row after the error, while the later valid insert produced a second audit row.
⚠️ Additional Finding Medium severity Rev Creating rev6_retry.f_quoted(rev6."Type,WithComma") fails with an internal error instead of creating the function. The later quoted-type lookup therefore cannot resolve the valid signature.
Additional Findings Details

These findings are unrelated to the current changes but were observed during testing.

🟡 Failed insert leaves a false audit record
  • Severity: Medium Medium severity
  • Description: The rejected insert returned the expected CHECK constraint error, but its BEFORE INSERT trigger wrote an audit row with amount -1. The target table had no row after the error, while the later valid insert produced a second audit row.
  • Impact: A rejected database write can leave a false audit record behind, even though the target row was not saved. This can mislead users and operators who rely on audit history to understand what actually happened.
  • Steps to Reproduce:
    1. Create a target table with a CHECK constraint that rejects negative amounts.
    2. Create an audit table and a BEFORE INSERT trigger that writes the new row to the audit table.
    3. Insert a negative amount and confirm that the CHECK constraint error is returned.
    4. Query the audit table, then insert a valid amount and query the audit table again.
  • Stub / mock content: No stubs, mocks, or bypasses were applied for this test in the recorded run.
  • Code Analysis: The production path wraps an INSERT with a BEFORE TriggerExecution node in server/analyzer/assign_triggers.go:50-64 and supplies the trigger body with a pgexprs.StatementRunner at line 59. TriggerExecution.BuildRowIter in server/node/trigger_execution.go:77-116 builds the source iterator and trigger functions, and triggerExecutionIter.Next at lines 222-306 invokes each trigger through plpgsql.TriggerCall at lines 243-265 before returning the row to the INSERT source. That structure allows the trigger body to perform an audit INSERT before the target row reaches constraint validation. The observed result shows the target write is discarded on the CHECK error but the audit write is retained, proving the trigger-body write is not participating in the same rollback scope. The PR diff only adds TgOp/getTriggerOperation wiring in server/analyzer/assign_triggers.go and moves the existing operation lookup into TriggerExecution; it does not add transaction boundaries or alter rollback handling. A targeted fix should execute trigger-body statements on the enclosing DML transaction context and ensure the statement-level rollback covers both the trigger write and the target write, without changing TG_OP behavior.
Evidence Package
🟡 Quoted composite types block function creation
  • Severity: Medium Medium severity
  • Description: Creating rev6_retry.f_quoted(rev6."Type,WithComma") fails with an internal error instead of creating the function. The later quoted-type lookup therefore cannot resolve the valid signature.
  • Impact: Users cannot create functions that use composite types with quoted names containing commas, so those valid function signatures cannot be resolved. Other function signatures continue to work, limiting the issue to this specific naming pattern.
  • Steps to Reproduce:
    1. Create a schema named rev6_retry.
    2. Create the composite type rev6_retry."Type,WithComma" with one integer field.
    3. Run CREATE FUNCTION rev6_retry.f_quoted(rev6."Type,WithComma") RETURNS integer LANGUAGE SQL IMMUTABLE AS $$ SELECT 1 $$;.
    4. Observe the error: root returned table rev6_retry.f_quoted(Type,WithComma) but it could not be found.
  • Stub / mock content: No stubs, mocks, or bypasses were applied for this test in the recorded run.
  • Code Analysis: The failure occurs before regprocedure resolution can exercise the quoted composite argument. The recorded SQL successfully creates the schema and composite type, then fails while creating the function with the quoted type. The error is emitted by the production table-hook path in server/hook/table_add_column.go: after obtaining all table names from the root, the hook calls root.GetTable and returns root returned table name ... but it could not be found? when the returned name cannot be looked up (lines 54-69). The observed message is the same root/table lookup failure family, with the routine name rendered as f_quoted(Type,WithComma), which indicates that the quoted comma-containing signature is being represented incorrectly while the create-function path updates catalog state. The regprocedure implementation itself adds delimiter-aware splitting in server/functions/regprocedure.go:188-215: commas are split only at depth zero and outside double quotes, so arrays and quoted type text are intended to remain intact. That parser is not reached for the failing CREATE FUNCTION statement. The smallest practical fix is to preserve the quoted composite type name as one identifier through function parsing and catalog/table-hook updates, then rerun the same CREATE FUNCTION and regprocedure lookup; avoid treating the comma inside the quoted identifier as a routine/table delimiter.
Evidence Package

Tip

Reply with @itoqa to send us feedback on this test run.

@itoqa

itoqa Bot commented Oct 8, 2026

Copy link
Copy Markdown

Ito QA test results
Ito Diff Report — c7426fa → e5c3638: 4 test cases ran, 4 passing ✅.

Diff Summary

Coverage centers on database scripting behavior: variable-processing flows complete successfully, supported cases remain eligible while incompatible cases are excluded, and expected script functionality remains discoverable. This is primarily happy-path and compatibility-boundary coverage, with no failures observed.

Safe to merge — no PR-attributable regressions, new failures, or previously flagged failures remain in this run. The results show the changed behavior is healthy, while unrelated historical findings are flag-for-later observations rather than merge blockers.

Tests run by Ito

View full run

Result State Severity Type Description
✅ Passing — General The variables test suite completed successfully through the Doltgres harness. No wrapper or delegation error occurred.
✅ Passing — General The variables script suite finished successfully. The configured incompatible cases were skipped, and no unexpected case failure or runner error was reported.
✅ Passing — Registration The variables script test is listed, and the removed views script test is not listed.
✅ Passing — Variables The retained variables test was discoverable and completed successfully through the Doltgres test harness.
⏸️ Skipped — General The required browser check used HTTP against a PostgreSQL database service, so it could not run the SQL scenario. The focused regression test passed, and the application code restores settings created after a savepoint when that savepoint is rolled back.
⏸️ Skipped — General The ordinary member could not create a database or table, read the protected table, or run the protected routine just because it belonged to a superuser group. A group grant allowed only the specific access it was given.
⏸️ Skipped — Identity The connection completed startup, showed the ordinary role as both session and current user, and successfully ran SELECT 1.
⏸️ Skipped — Inheritance A direct grant, a broader schema grant, and group membership each let the correct role read the protected row.
⏸️ Skipped — Journal The same database session kept the session value after COMMIT, discarded the local value, and restored the earlier value after ROLLBACK.
⏸️ Skipped — Privilege After switching to the member role, the protected query returned the member-only row. Resetting the role restored the login role.
⏸️ Skipped — Regprocedure A local procedure was created, and its OID, integer, and regproc values all converted to regprocedure with the same procedure identity.
⏸️ Skipped — Role The client changed to the authorized target role and RESET ROLE restored the original client role.
⏸️ Skipped — Role The database rejected an unauthorized role change, reported a missing role, and rejected a multiple-value role command with the expected errors.
⏸️ Skipped — Setting The session kept its setting after SET, showed the local value inside the transaction, restored the session value after ROLLBACK, and reset application_name to its default.
⏸️ Skipped — Trigger Verified acceptable by independent adversarial review: the reported expectation does not match what the code actually promises. Review notes: The rejection is real, but the finding turns the PR's internal operation mapping into a new feature obligation that the change does not establish. The PR fixes TG_OP propagation for supported row triggers, its added test covers only INSERT, UPDATE, and DELETE, and the unchanged CREATE TRIGGER conversion still marks both statement-level and TRUNCATE triggers as unsupported. Those guards describe a …
Tests that are no longer relevant

Below are tests that previously ran and are no longer relevant:

Type Test Description
General All themed test entry points load together Dropped because The test requires all exposed themed entry points to be discoverable and runnable; the six-line TestViewsScripts registration block was deleted from testing/go/enginetest/doltgres_engine_test.go.
Compatibility Upgraded scripts run through PostgreSQL compatibility checks Dropped because The test asserts execution of the enabled themed wrappers through the harness, but testing/go/enginetest/doltgres_engine_test.go removes the TestViewsScripts wrapper from that set.
Harness Skips and cleanup work across the full suite Dropped because The full sequential themed-suite run explicitly covers all wrappers; the deleted func TestViewsScripts in testing/go/enginetest/doltgres_engine_test.go is no longer part of that target set.
Suites Themed script suites pass Dropped because The test requires every enabled themed wrapper, including the local TestViewsScripts wrapper, but testing/go/enginetest/doltgres_engine_test.go deletes func TestViewsScripts and its harness delegation.
General Failed insert leaves a false audit record Dropped because The prior DML trigger side-effect failure is outside this commit's dependency and enginetest registration changes.
Catalog Catalog rows fail inside whole-row functions Dropped because The prior catalog alias expansion failure is outside this commit's dependency and enginetest registration changes.
Rev Quoted composite types block function creation Dropped because The prior regprocedure resolution failure is outside this commit's dependency and enginetest registration changes.

Tip

Reply with @itoqa to send us feedback on this test run.

@itoqa

itoqa Bot commented Oct 9, 2026

Copy link
Copy Markdown

Ito QA test results
Ito Diff Report — e5c3638 → dd5003d: 12 test cases ran, 12 passing ✅.

Diff Summary

Coverage spans normal execution of database scripts and views, discovery of registered behavior, compatibility handling, and clear failure reporting for missing definitions. It also exercises edge cases around transactions, invalid views, and table-warning behavior, with the application behavior remaining healthy throughout.

Safe to merge — no regressions, new failures, or previously reported PR-related failures were found, and the exercised execution and compatibility behaviors all remain healthy. No merge blocker is indicated.

Tests run by Ito

View full run

Result State Severity Type Description
✅ Passing — General The selected JSON and procedure cases were found and ran successfully. The one case covered by the shared compatibility policy was clearly skipped instead of disappearing silently.
✅ Passing — General The retained variables tests and selected view tests completed through the shared Doltgres harness. Policy-matching cases were clearly skipped, while eligible view cases ran and passed through the upstream script runner.
✅ Passing — Harness The variables script suite created the Doltgres test harness, completed its checks, and ended with a passing result.
✅ Passing — Rev Module verification succeeded, and the selected view, JSON, and procedure tests compiled and completed successfully.
✅ Passing — Rev The DROP TABLE warning checks completed successfully with no SQL error, panic, or leftover table-state failure.
✅ Passing — Scripts The selected JSON and procedure script cases were found and completed successfully. The transaction procedure case was skipped by the shared compatibility policy, as expected.
✅ Passing — Scripts The selected transaction procedure case was found and marked skipped by the shared compatibility policy, as expected.
✅ Passing — Views The five selected view checks were found. Four were skipped by the compatibility rules, and the eligible check ran successfully.
✅ Passing — Views The full view test suite was discovered, explicitly skipped, and the test package finished successfully.
✅ Passing — Views A missing relocated view name made the test fail and included the exact name in the error. This prevents a stale registration from being silently ignored.
✅ Passing — Warnings The warning test created the database harness, loaded the standard data, and finished successfully with stored-procedure checks disabled. The incompatible warning case was clearly skipped by policy.
✅ Passing — Warnings The warning suite passed. The incompatible warning case was explicitly skipped, while the suite remained eligible to run through the shared warning runner.
⏸️ Skipped — General The variables test suite completed successfully through the Doltgres harness. No wrapper or delegation error occurred.
⏸️ Skipped — General The variables script suite finished successfully. The configured incompatible cases were skipped, and no unexpected case failure or runner error was reported.
⏸️ Skipped — Registration The variables script test is listed, and the removed views script test is not listed.
⏸️ Skipped — Rev All twelve expected test suites were listed exactly once, and a targeted run completed all twelve successfully.
⏸️ Skipped — Variables The retained variables test was discoverable and completed successfully through the Doltgres test harness.

Tip

Reply with @itoqa to send us feedback on this test run.

@zachmu
zachmu merged commit 7a62b33 into main Oct 10, 2026
23 checks passed
@zachmu
zachmu deleted the zachmu/split-script-queries branch October 10, 2026 00:35
@itoqa

itoqa Bot commented Oct 10, 2026

Copy link
Copy Markdown

Ito QA test results
Ito Diff Report — dd5003d → 5c665a0: 14 test cases ran, 14 passing ✅.

Diff Summary

Coverage spans normal and edge-case database cursor behavior, including movement in multiple directions, zero-row operations, transaction and lifetime handling, catalog visibility, option validation, identifier parsing, and rapid close-and-reopen flows. Adversarial checks also confirm that unsupported rewinding behavior is rejected as intended, with the exercised behavior broadly healthy.

Safe to merge — the run found no PR-attributable regressions or new failures, and the reviewed behavior is consistent with the documented contract. Some previously passing areas were not exercised or were removed as obsolete, so they remain follow-up coverage considerations rather than merge blockers.

Tests run by Ito

View full run

Result State Severity Type Description
✅ Passing — General Zero-count reads at both ends returned no rows, movement stayed at zero, and the cursor closed cleanly.
✅ Passing — General Verified acceptable by independent adversarial review: the observed behavior is intended and documented in this codebase. Review notes: The mechanism is real and reachable: MOVE dispatches to Cursor.Move, and an advanced NO SCROLL cursor reaches rewind and receives errScanForwardOnly. The finding's obligation is nevertheless the inverse of the cited source: the comment expressly limits the MOVE BACKWARD ALL exception to a non-scrollable cursor already at position zero, while rewind intentionally rejects nonzero positions and the d…
✅ Passing — General The requested catalog check was blocked because the target accepts PostgreSQL connections, not browser pages. Repository cursor tests cover normal catalog listing and cleanup, but this run did not execute the concurrent snapshot steps.
✅ Passing — General CLOSE ALL removed both original cursors, and the retried c_one became the only catalog entry. The replacement cursor stayed fetchable, while c_two and the cursor closed afterward were invalid.
✅ Passing — Catalog The cursor catalog showed both open cursors with the expected names, statements, and flags, then became empty after the cursors were closed.
✅ Passing — Cursor The cursor returned the first two rows, moved past two more rows, returned the expected row when moving backward, and closed successfully.
✅ Passing — Cursor Absolute and relative moves returned the expected rows, zero-count movement kept the current-row behavior, and moving backward through all rows rewound the cursor correctly.
✅ Passing — Cursor Verified acceptable by independent adversarial review: the observed behavior is intended and documented in this codebase. Review notes: The finding misreads both the sentinel and the stated contract. FetchAll is positive, so MOVE BACKWARD ALL does enter the special branch, but the branch intentionally allows a NO SCROLL cursor only when no backward movement is needed; after forward movement, rewind deliberately returns the scan-forward-only error. The cited test verifies only that initial-position no-op and provides no obligation …
✅ Passing — Declare The supported cursor syntax was accepted. Fetch returned rows, Move reported the moved count, and Close completed successfully.
✅ Passing — Declare The server rejects SCROLL with NO SCROLL and rejects unsupported BINARY cursors. Neither invalid declaration creates a cursor.
✅ Passing — Parse The function returned the expected text arrays for qualified names, kept quoted text unchanged, and decoded doubled quotes.
✅ Passing — Parse Trailing text is accepted in non-strict mode, rejected in strict mode, and a trailing dot is rejected.
✅ Passing — Transaction Non-holdable cursors close when a transaction rolls back, while holdable cursors remain available after a successful commit and return their rows.
✅ Passing — Transaction Rolling back removes the holdable cursor, and the same connection can run another query afterward.
⏸️ Skipped — General The retained variables tests and selected view tests completed through the shared Doltgres harness. Policy-matching cases were clearly skipped, while eligible view cases ran and passed through the upstream script runner.
⏸️ Skipped — Harness The variables script suite created the Doltgres test harness, completed its checks, and ended with a passing result.
⏸️ Skipped — Rev The DROP TABLE warning checks completed successfully with no SQL error, panic, or leftover table-state failure.
⏸️ Skipped — Warnings The warning test created the database harness, loaded the standard data, and finished successfully with stored-procedure checks disabled. The incompatible warning case was clearly skipped by policy.
⏸️ Skipped — Warnings The warning suite passed. The incompatible warning case was explicitly skipped, while the suite remained eligible to run through the shared warning runner.
Tests that are no longer relevant

Below are tests that previously ran and are no longer relevant:

Type Test Description
General Script names stay aligned Dropped because The relocated JSON and procedure registrations referenced by this integration test were deleted from testing/go/enginetest/doltgres_engine_test.go; TestRelocatedJsonScripts and TestRelocatedProcedureScripts no longer exist.
Rev Module snapshot and engine tests pass Dropped because The module snapshots asserted by the test were replaced in go.mod: dolt/go and go-mysql-server now resolve to newer revisions, so the old reproducibility target is gone.
Scripts JSON and procedure scripts run successfully Dropped because The TestRelocatedJsonScripts and TestRelocatedProcedureScripts registrations asserted by this test are absent after the testing/go/enginetest/doltgres_engine_test.go change; no replacement with those symbols remains.
Scripts Selected procedure case is skipped Dropped because The relocated JSON/procedure helper and its selected-case skip path were removed from testing/go/enginetest/doltgres_engine_test.go, so the asserted helper behavior is gone rather than merely untested.
Views Selected view checks run successfully Dropped because The selected relocated-view registration and helper are removed from testing/go/enginetest/doltgres_engine_test.go; the current file has TestViews instead and no TestRelocatedViewScripts symbol.
Views Full view suite remains skipped Dropped because The t.Skip behavior asserted for TestViews was deleted from testing/go/enginetest/doltgres_engine_test.go; the current TestViews now creates a harness and executes queries.ViewScripts.
Views Missing view names fail clearly Dropped because The absent-name check for the relocated view helper is no longer represented: the relocated helper and its requested-name lookup path were deleted from testing/go/enginetest/doltgres_engine_test.go.

Tip

Reply with @itoqa to send us feedback on this test run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants