feat(magit): replace github-review for code-review - #5846
Merged
Merged
Conversation
elken
marked this pull request as ready for review
November 28, 2021 10:15
elken
force-pushed
the
feat/code-review
branch
3 times, most recently
from
November 28, 2021 14:54
5450282 to
b0fa641
Compare
Contributor
Author
|
Discussion here on handling bindings, so the snippet might end up being removed. |
hlissner
added
is:feature
elken
force-pushed
the
feat/code-review
branch
2 times, most recently
from
December 6, 2021 14:54
2897400 to
0c9e799
Compare
hlissner
requested changes
Dec 14, 2021
hlissner
left a comment
hlissner
left a comment
Member
There was a problem hiding this comment.
Sorry for the late response! Could you:
- bump
:tools magitonce more (and squash it into the latest bump commit)? - Move the changes to README.org to the rewrite-docs branch?
Contributor
Author
No worries
Under another PR? Sure |
elken
force-pushed
the
feat/code-review
branch
from
December 15, 2021 06:58
0c9e799 to
6d2c96b
Compare
elken
force-pushed
the
feat/code-review
branch
from
December 15, 2021 07:07
6d2c96b to
8169b6a
Compare
elken
added a commit
to elken/doomemacs
that referenced
this pull request
Dec 15, 2021
hlissner
approved these changes
Dec 15, 2021
Member
|
Thanks again for your help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code-review is considered to be a superset of github-review, and as well
as supporting more forges (gitlab support is WIP) also better fits in
with magit.
Fix: #5812