Conversation
33 tasks
guardrex
force-pushed
the
guardrex/fundamentals-startup
branch
from
September 8, 2026 11:44
2a0ed77 to
f8c5978
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
guardrex
marked this pull request as ready for review
September 9, 2026 19:18
guardrex
requested review from
wadepickett
and
a lite review from Copilot
and removed request for
ilonatommy
September 17, 2026 17:26
Added a custom response header filter and updated service registration. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Clarified the description of the `ServerReady` event to include its role in measuring startup time. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
guardrex
marked this pull request as ready for review
September 18, 2026 13:35
wadepickett
reviewed
Sep 18, 2026
wadepickett
reviewed
Sep 18, 2026
wadepickett
approved these changes
Sep 18, 2026
wadepickett
left a comment
Contributor
There was a problem hiding this comment.
@guardrex: Approved, but note my inline suggestion.
Co-authored-by: Wade Pickett <wpickett@microsoft.com>
Collaborator
Author
|
@wadepickett ... Got it ... I added the versioning for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37590
Fixes #37681
Addresses #34356
Notes
Wade ... Engineers are too busy to look at this one. Let's go ahead on our own and try to get it reviewed, updated, and merged. Remaining Copilot suggestions are either unclear or unimportant, such as its insistence that we keep the dreaded named anchors. This is ready for review! 🎉
Per our brief convo on the Fundamentals overview PR, we might need to discuss these in-repo samples further. I don't understand the concern about dropping them. IMO, the tutorials, such as the Blazor tutorials, are the best way to walk a dev through working code for base case learning scenarios. Then, advanced samples exist for difficult concepts that run under recent/current .NET versions with modern tooling and C# language versions that are easily accessible for inspection and download.
Startupclass coverage only appearing for <6.0 in spite of current support, I think that was a management decision because the PU wants devs to focus on the minimal hosting model. We have some current version content to cross-link the article's 5.0 version if a dev is upgrading an app and looking for the coverage. I left this paradigm in place for theStartupclass coverage.ServerReady/startup performance is worth a mention, but I place a new, short section on it in the Logging overview (as anEventSourcesubsection) and cross-link to it there.Internal previews
Build report