chore: Remove extra space that is added by AppendArgument#3183
Open
filzrev wants to merge 1 commit into
Open
Conversation
filzrev
force-pushed
the
chore-remove-extra-space-of-appendargument
branch
from
a9f7c3e to
6d976a6
Compare
timcassell
reviewed
Jun 23, 2026
| [InlineData(" a ", "a")] | ||
| [InlineData(" a ", "a")] | ||
| [InlineData(" \r\n a \r\n", "a")] | ||
| public void AppendArgumentMakesSureOneSpaceBeforeStringArgument(string? input, string expectedOutput) |
Collaborator
There was a problem hiding this comment.
Tests should be updated to test both single- and multi-argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modify
AppendArgumentextension method for StringBuilder.This extension method is used by DotNetCliCommand.cs
And it add extra space between
dotnetand sub command (e.g.dotnet restore)This PR remove extra space to make it easier to grep from logs.