Repository navigation
Add a pooling data source - #2635
Merged
Merged
Conversation
mdaigle
requested review from
VladimirReshetnikov,
benrr101,
cheenamalhotra,
samsharma2700 and
saurabh500
July 1, 2024 19:07
vonzshik
reviewed
Jul 1, 2024
saurabh500
reviewed
Jul 1, 2024
| //TODO: support auth contexts and provider info | ||
| PoolingDataSource(SqlConnectionStringBuilder connectionStringBuilder, | ||
| SqlCredential credential, | ||
| RemoteCertificateValidationCallback userCertificateValidationCallback, |
Collaborator
There was a problem hiding this comment.
Why do these callbacks exist?
Contributor
Author
There was a problem hiding this comment.
I think this is a holdover from npgsql inspiration. I can clean them up and come back around later as the auth flows are fleshed out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the skeleton of a concrete, pooling SqlDataSource class.
Introduces a "return" flow so that data sources can received an internal connection for recycling or closing.