Add support for .NET 9

[mdaigle]

Enhancements:

• Adds .NET 9 to target frameworks

Fixes:

• Adds missing DynamicallyAccessedMembers attribute to GetProviderSpecificFieldType and GetFieldType in netcore ref project.
  • Removes suppressions due to missing annotations in net6.0
• Switches X509Certificate construction to use X509CertificateLoader.
• Switches PKCS decoding to use SignedCMS.
• Adds internal ReadExactly extension to System.IO.Stream in netfx to provide API parity between netcore and netfx and to address CA2022.
• Guards ServicePointManager usage to netfx only, deprecated in .NET 9
  • https://learn.microsoft.com/en-us/dotnet/fundamentals/syslib-diagnostics/syslib0014
  • https://learn.microsoft.com/en-us/dotnet/api/system.net.servicepointmanager?view=net-9.0

Package Versions:

• Adds System.Security.Cryptography.Pkcs:9.0.0 to address SYSLIB0057
• Adds Microsoft.Bcl.Cryptography:9.0.0, dependency of the pkcs package
• Bumps Microsoft.Extensions.Caching.Memory to 9.0.0
• Bumps System.Configuration.ConfigurationManager to 9.0.0

Test Dependencies:

• Bumps Microsoft.DotNet.RemoteExecutor to 10.0.0-beta.24564.1
• Bumps Xunit to 2.6.3 for all frameworks

[roji]

Am curious - is there any net9.0 API that's actually needed/used? If not, is there a specific reason to add the net9.0 TFM?

[David-Engel]

Am curious - is there any net9.0 API that's actually needed/used? If not, is there a specific reason to add the net9.0 TFM?

@roji JSON support in SqlDbType: dotnet/runtime#103925

[roji]

@David-Engel of course, I forgot about that, thanks :)

[codecov]

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.

Project coverage is 72.60%. Comparing base (1348c3c) to head (6ac682e).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...c/Microsoft/Data/SqlClient/Server/SqlNormalizer.cs	0.00%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2946      +/-   ##
==========================================
- Coverage   72.67%   72.60%   -0.08%     
==========================================
  Files         285      285              
  Lines       59160    59162       +2     
==========================================
- Hits        42997    42954      -43     
- Misses      16163    16208      +45     

Flag	Coverage Δ
addons	92.58% <ø> (ø)
netcore	75.40% <35.71%> (-0.04%)	⬇️
netfx	71.00% <30.76%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[edwardneal]

Is there a shared path we can put this which both the test projects and M.D.S can refer to? It's identical to src/Microsoft.Data.SqlClient/src/System/IO/StreamExtensions.netfx.cs.

[cheenamalhotra]

Ideally, I would create a Common/Shared project that both test and src projects depend on, but this class is too small for that. If we have more cases like this, we can consider coming up with a common project.

[benrr101]

@mdaigle Like I said in the previous PR, internals of the MDS projects should be visible to the test projects. If they aren't, then we should make them so.

@cheenamalhotra I personally don't think we need to add another project for this purpose, if we leverage internalsvisibleto. We can discuss more if we need to, tho.

[cheenamalhotra]

Ideally, I would create a Common/Shared project that both test and src projects depend on, but this class is too small for that. If we have more cases like this, we can consider coming up with a common project.

[cheenamalhotra]

Can you elaborate on this change?

[mdaigle]

ServicePointManager is marked as obsolete in Net 9.
https://learn.microsoft.com/en-us/dotnet/fundamentals/syslib-diagnostics/syslib0014
I removed the call to no effect in the tests, so it didn't seem to be changing anything. But if there's any concern, I can add a suppression instead.

[benrr101]

@mdaigle Are you sure it's the ServicePointManager? I had seen similar warnings in the code when using Tls12 security type.

[benrr101]

Looks good to me in general. I think we should make InternalsVisibleTo test projects (I think that change was only made in the clientx branch) so we can avoid duplication of the stream extensions. But I won't hold up approval on that.